Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#481 closed Bug (fixed)

username should be enclosed in double quotes in config files, in case the user name contains a =

Reported by: matt Owned by:
Priority: major Milestone: RobotRock
Component: Core Keywords:
Cc: Sensitive:

Description

From bug report: http://forum.piwik.org/index.php?showtopic=70

In the config file we should have

username = "my=username"

instead of

username = my=username

the same way the password is currently enclosed in double quotes

Change History (3)

comment:1 Changed 5 years ago by vipsoft (robocoder)

from #570, host should also be enclosed in quotes.

comment:2 Changed 5 years ago by matt (mattab)

  • Resolution set to fixed
  • Status changed from new to closed

fixed in [949]

--> all non-array values in Config/config.ini.php are now automatically enclosed in double quotes, and double quote automatically encoded as " (parse_ini_file doesn't handle escaping the double quote, arg)

cleaning the Piwik_Config code, adding tests, the code using the Config is now more simple, all the logic is inside the class (before it was very hacky). the installer is now using the Config to create the config file rather than duplicating the logic.

comment:3 Changed 5 years ago by domtop

Note: See TracTickets for help on using tickets.