Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

username should be enclosed in double quotes in config files, in case the user name contains a = #481

Closed
mattab opened this issue Dec 26, 2008 · 2 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.

Comments

@mattab
Copy link
Member

mattab commented Dec 26, 2008

From bug report: http://forum.piwik.org/index.php?showtopic=70

In the config file we should have

```
username = “my=username”
```

instead of

```
username = my=username
```

the same way the password is currently enclosed in double quotes

@robocoder
Copy link
Contributor

from #570, host should also be enclosed in quotes.

@mattab
Copy link
Member Author

mattab commented Mar 2, 2009

fixed in 949

—> all non-array values in Config/config.ini.php are now automatically enclosed in double quotes, and double quote automatically encoded as " (parse_ini_file doesn’t handle escaping the double quote, arg)

cleaning the Piwik_Config code, adding tests, the code using the Config is now more simple, all the logic is inside the class (before it was very hacky). the installer is now using the Config to create the config file rather than duplicating the logic.

@mattab mattab added this to the RobotRock milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

3 participants