Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge case: page view and ecommerce conversion tracked in the same second create wrong visitEcommerceStatus #4909

Closed
mattab opened this issue Mar 26, 2014 · 6 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Mar 26, 2014

After staring at the code for two hours, then getting good debug data, I figured the bug: if a page view is tracked at the same second as an ecommerce order, this pageview request may erase the visitEcommerceStatus flag.

Explanation:

  1. the ecommerce order request is received
  2. at same time the pageview for the checkout page is tracked.
    This page view "reads" first the visit (which does not yet have "visitEcommerceStatus == ordered")
    1b) the ecommerce is recorded and "visitEcommerceStatus == ordered" is set
    2b) the pageview is recorded and "visitEcommerceStatus == none"
@mattab
Copy link
Member Author

mattab commented Mar 26, 2014

In 5809c35: Refs #4909 Only update the visitEcommerceStatus flag if it's not NONE.
This will prevent some occurrences of this bug, but not the case where visitEcommerceStatus == abandonedCart

@mattab
Copy link
Member Author

mattab commented Mar 26, 2014

There are two solutions to this bug:

@mattab
Copy link
Member Author

mattab commented Mar 26, 2014

In 25bfb48: Refs #4909 Only update the visitEcommerceStatus flag if it's different from current value.

@mattab
Copy link
Member Author

mattab commented Mar 26, 2014

After that last commit I think this should fix the issue. So #4910 is not necessary.

@mattab
Copy link
Member Author

mattab commented Aug 20, 2014

see also #5966

sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
…s not NONE.

This will prevent some occurrences of this bug, but not the case where visitEcommerceStatus == abandonedCart
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Copy link
Member Author

mattab commented Mar 15, 2016

See also: #9916 It is not possible to record more than one conversion per second for the same visit

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

1 participant