Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When a plugin requires a max Piwik core version, disable the plugin on update #4967

Closed
mattab opened this issue Apr 8, 2014 · 6 comments
Closed

When a plugin requires a max Piwik core version, disable the plugin on update #4967

mattab opened this issue Apr 8, 2014 · 6 comments
Assignees
@tsteur
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone
2.2.0

Comments

@mattab
Copy link
Member

mattab commented Apr 8, 2014

Goal: introduce a mechanism to disable plugin on upgrade to a more recent Piwik core version. This is part of making Piwik the best open platform for data analytics!

Example Use case

  • A plugin requires Piwik`

    =2.0,<2.4`

    • User upgrades from Piwik 2.1.0 to 2.4.0
    • On the page that says "Click to update automatically or download to update manually"
    • we add the following message if any plugin requires a version that will not be met after upgrade.
    • After the upgrade, Piwik core should detect that there is currently an "activated" plugin that does not meet the "require" found in plugin.json. Piwik core should then "deactivate" this plugin.
    • In the "Manage > Plugins" screen, when user clicks "Activate" on the plugin, show the following message in the page (either full page error or notification are OK) "EnterpriseAdmin requires Piwik <= 2.2.0. Please [here to email $Developer_Name /email_link and enquire about an updated version of EnterpriseAdmin."

Message in the pre-Upgrade screen

Note: some plugins are not compatible with Piwik 2.4.0. They will be disabled when you upgrade:

  • EnterpriseAdmin requires Piwik <= 2.2.0. Please [here to email $Developer_Name /email_link and enquire about an updated version of EnterpriseAdmin.
  • Plugin2 requires Piwik <= 2.2.8. Please [here to email $Developer_Name /email_link and enquire about an updated version of Plugin2.

Refs
@tsteur
Copy link
Member

tsteur commented Apr 9, 2014

In 918355e: refs #4967 started to work on verifying plugin version during run time and before update. Not 100% tested yet, especially not the updater yet

@tsteur
Copy link
Member

tsteur commented Apr 9, 2014

In 58291bc: refs #4967 actually disable plugin during update if needed

@tsteur
Copy link
Member

tsteur commented Apr 9, 2014

In 681e655: refs #4967 display missing requirements a bit more consistent

@tsteur
Copy link
Member

tsteur commented Apr 9, 2014

In af52593: refs #4967 better tests

@tsteur
Copy link
Member

tsteur commented Apr 9, 2014

In 218e898: refs #4967 handle whitespace

@tsteur
Copy link
Member

tsteur commented Apr 9, 2014

"$PluginName requires $Dependency $comparison $PluginVersion" will be always displayed.

"Please email $email and enquire an updated version of $PluginName" will be only displayed if the plugin is not available on the Marketplace and only if the plugin has defined a support email address as defined here: https://getcomposer.org/doc/04-schema.md#support

@mattab mattab added this to the 2.2.0 - Piwik 2.2.0 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
2 participants
@tsteur @mattab