Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JShrink has broken things #4970

Closed
tassoman opened this issue Apr 9, 2014 · 2 comments
Closed

JShrink has broken things #4970

tassoman opened this issue Apr 9, 2014 · 2 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. worksforme The issue cannot be reproduced and things work as intended.
Milestone
2.2.1

Comments

@tassoman
Copy link
Contributor

tassoman commented Apr 9, 2014

Well, after a composer update I've got the following error:

[Wed Apr 09 10:43:33 2014] [error] [client 10.11.2.115] PHP Fatal error:  Maximum execution time of 30 seconds exceeded in /var/www/piwik/vendor/tedivm/jshrink/src/JShrink/Minifier.php on line 177, referer: http://vmdev.local/piwik/index.php?module=CoreHome&action=index&idSite=1&period=day&date=today
[Wed Apr 09 10:43:33 2014] [error] [client 10.11.2.115] PHP Stack trace:, referer: http://vmdev.local/piwik/index.php?module=CoreHome&action=index&idSite=1&period=day&date=today

I've also tried updating requirements to 0.5.2 in composer.json but stills broken
@sgiehl
Copy link
Member

sgiehl commented Apr 9, 2014

Please have a look at http://piwik.org/faq/troubleshooting/#faq_103
Changing the maximum execution time should fix your problem.

@tassoman
Copy link
Contributor Author

tassoman commented Apr 9, 2014

Well, it worked extending max execution time to 120 seconds
Thank you for help. BTW JShrink stable looks like 5.2.0, working well with piwik master branch. Is just a bit laggy compiling javascripts because of machine load.

@tassoman tassoman added this to the 2.2.1 - Piwik 2.2.1 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. worksforme The issue cannot be reproduced and things work as intended.
Projects
None yet
Milestone
2.2.1
Development

No branches or pull requests
3 participants
@tassoman @mattab @sgiehl