Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Composer to require PHPUnit #5031

Closed
sgiehl opened this issue Apr 23, 2014 · 10 comments
Closed

Use Composer to require PHPUnit #5031

sgiehl opened this issue Apr 23, 2014 · 10 comments
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone

Comments

@sgiehl
Copy link
Member

sgiehl commented Apr 23, 2014

The PHPUnit PEAR channel will be closed by the end of the year. The prefered way of installing PHPUnit is no longer PEAR.

https://github.com/sebastianbergmann/phpunit/wiki/End-of-Life-for-PEAR-Installation-Method

We should require PHPUnit using composer.

@julienmoumne
Copy link
Member

+1

@mattab
Copy link
Member

mattab commented May 1, 2014

In f927ccd: Refs #5031 Now getting PHPUnit from composer/packagist. This will make like better for core team devs
Updating readme with instructions.
I also hope this will solve the Autoloader issue on the UI build: https://travis-ci.org/piwik/piwik-ui-tests

@mattab
Copy link
Member

mattab commented May 1, 2014

In cf6d408: Adding PHPUnit to include path, maybe this helps? refs #5031
Error was https://travis-ci.org/piwik/piwik/jobs/24163923

@mattab
Copy link
Member

mattab commented May 1, 2014

In 4d46007: PHPUnit doc says to add vendor/bin to include path refs #5031

@mattab
Copy link
Member

mattab commented May 1, 2014

In d29e037: Trying with PHPUnit 4 to match the one used by travis refs #5031

@mattab
Copy link
Member

mattab commented May 1, 2014

In a215035: Refs #5031 The build is green: https://travis-ci.org/piwik/piwik we're running latest PHPUnit using composer.

Instructions to install PHPUnit, run php composer.phar update in the Piwik root directory.

             Add the PHPUnit binary path to the your PATH environment variable. For example on Linux:
             Edit `.bashrc` in your home directory and add the following line:

                 export PATH=/path/to/dir:$PATH

             You will need to source your `.bashrc` or logout/login (or restart the terminal) for the changes to take effect.
             To source your `.bashrc`, in your home directory simply type

                 $ source .bashrc

             See [doc](PHPUnit)(http://www.phpunit.de/manual/current/en/installation.html).

@mattab
Copy link
Member

mattab commented May 1, 2014

Done

@sgiehl
Copy link
Member Author

sgiehl commented May 1, 2014

Should we maybe adjust the RunTests console to use vendor/phpunit/phpunit/phpunit as executable? that would make it possible to use it without adjusting the PATH I guess.

@mattab
Copy link
Member

mattab commented May 1, 2014

+1 for making the console command work without PATH update!

@mattab
Copy link
Member

mattab commented May 4, 2014

In e91bfbc: Refs #5031 use the phpunit binary from composer

@sgiehl sgiehl added this to the 2.x - The Great Piwik 2.x Backlog milestone Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
…s will make like better for core team devs

Updating readme with instructions.
I also hope this will solve the Autoloader issue on the UI build: https://travis-ci.org/piwik/piwik-ui-tests
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
…piwik we're running latest PHPUnit using composer.

Instructions to install PHPUnit, run `php composer.phar update` in the Piwik root directory.

                 Add the PHPUnit binary path to the your PATH environment variable. For example on Linux:
                 Edit `.bashrc` in your home directory and add the following line:

                     export PATH=/path/to/dir:$PATH

                 You will need to source your `.bashrc` or logout/login (or restart the terminal) for the changes to take effect.
                 To source your `.bashrc`, in your home directory simply type

                     $ source .bashrc

                 See [PHPUnit doc](http://www.phpunit.de/manual/current/en/installation.html).
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

No branches or pull requests

3 participants