Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Piwik will chmod files created in tmp/* 750 instead of 755 #5034

Closed
mattab opened this issue Apr 23, 2014 · 2 comments
Closed

Piwik will chmod files created in tmp/* 750 instead of 755 #5034

mattab opened this issue Apr 23, 2014 · 2 comments
Assignees
@mattab
Labels
Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
2.3.0

Comments

@mattab
Copy link
Member

mattab commented Apr 23, 2014

For increasing security, Piwik should chmod files in tmp/ folder with 0750 permission (instead of current 755).

  • Update chmod commands
  • Update the messages shown on screen that mention "chmod"

follows up #1833, #4046
@mattab
Copy link
Member Author

mattab commented May 8, 2014

In f1f4a7a: Fixes #5034 chmod files created in tmp/* as 0750 instead of 0755
The code should fallback to 0755 if the webserver user still cannot write to the directory.

@mattab
Copy link
Member Author

mattab commented May 24, 2014

In 6c6e5e9: Refs #5034 Only restrict chmod 0750 to folders in tmp/*
It causes otherwise issues with folders in plugins/* which serve assets such as HTML files (for AngularJS modules)

@mattab mattab added this to the 2.3.0 - Piwik 2.3.0 milestone Jul 8, 2014
@mattab mattab self-assigned this Jul 8, 2014
@mattab mattab mentioned this issue May 24, 2014
Closed
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Fixes matomo-org#5034 chmod files created in tmp/* as 0750 instead of…
f1f4a7a 
… 0755

The code should fallback to 0755 if the webserver user still cannot write to the directory.
This was referenced Mar 4, 2015
Closed
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattab mattab

Labels
Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
2.3.0
Development

No branches or pull requests
1 participant
@mattab