We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The FastCGI check in the setHttpStatus function of ProxyHttp.php is invalid.
The function checks the PHP_SAPI global variable for existence of -fcgi in it, but the "if and else" blocks in the check are inverted.
It triggers the code for apache when the string contains -fcgi.
This issue was present in the 2.2.0 branch, and is also present (but in a slightly variated form) in the current master branch.
Line 224 in ProxyHttp.php changes from:
if (strpos(PHP_SAPI, '-fcgi') !== false) {
to
if (strpos(PHP_SAPI, '-fcgi') === false) {
if (substr_compare(PHP_SAPI, '-fcgi', -5)) {
if (! substr_compare(PHP_SAPI, '-fcgi', -5)) {
The text was updated successfully, but these errors were encountered:
Created a pull request 267 on github
Sorry, something went wrong.
In 46ff685: Merge pull request #267 from shabeepk/master
Fixes #5064 - Fixing the FastCGI check in setHttpStatus function of ProxyHttp.php file. Good catch, thanks for the Pull request 👍
Fix for matomo-org#5064
8e4e90c
Fixing the FastCGI check in setHttpStatus function of ProxyHttp.php file. Ticket matomo-org#5064
Merge pull request matomo-org#267 from shabeepk/master
46ff685
Fixes matomo-org#5064 - Fixing the FastCGI check in setHttpStatus function of ProxyHttp.php file. Good catch, thanks for the Pull request 👍
mattab
No branches or pull requests
The FastCGI check in the setHttpStatus function of ProxyHttp.php is invalid.
The function checks the PHP_SAPI global variable for existence of -fcgi in it, but the "if and else" blocks in the check are inverted.
It triggers the code for apache when the string contains -fcgi.
This issue was present in the 2.2.0 branch, and is also present (but in a slightly variated form) in the current master branch.
Fix for Master Branch
Line 224 in ProxyHttp.php changes from:
to
Fix for 2.2.0 Branch
Line 224 in ProxyHttp.php changes from:
to
The text was updated successfully, but these errors were encountered: