Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable access level for Segment Editor #5172

Closed
d-skora opened this issue May 15, 2014 · 8 comments
Closed

Configurable access level for Segment Editor #5172

d-skora opened this issue May 15, 2014 · 8 comments
Assignees
@mattab
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone
2.3.0

Comments

@d-skora
Copy link

d-skora commented May 15, 2014

Currently, any non-anonymous logged-in user, can add new segment.

Expected: as a Piwik admin I want to set that only users with "view" or "admin" or "superuser" permission can create new segments.
@mattab
Copy link
Member

mattab commented May 19, 2014

Thanks for the suggestion! See pull request: #275

@mattab
Copy link
Member

mattab commented May 21, 2014

In 22227f6: Merge pull request #275 from d-skora/feature/SegmentEditor

Feature/segment editor Fixes #5172

@mattab
Copy link
Member

mattab commented May 22, 2014

I realised the ticket description was not clear, and so the code IMHO is not correct.

I will commit some fix.

@mattab
Copy link
Member

mattab commented May 22, 2014

In bdc6dbb: Refs #5172 Make sure anonymous user cannot edit segments + rename superadmin to superuser for consistency

@mattab
Copy link
Member

mattab commented May 22, 2014

In f1c47b8: Refs #5172 Rename siteid to idSite for consistency

@mattab
Copy link
Member

mattab commented May 22, 2014

In a1577f2: Refs #5172 Fix bug, use proper idSite value

@mattab
Copy link
Member

mattab commented May 22, 2014

In 8885f29: Refs #5172 Rename config setting with a clear name, adding_segment_requires_access
idSite===false is not valid use case AFAIK so removing code that deals with that.

@mattab
Copy link
Member

mattab commented May 22, 2014

In 75871ca: Fixes #5172 Should be code complete

@d-skora d-skora added this to the 2.3.0 - Piwik 2.3.0 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattab mattab

Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
2.3.0
Development

No branches or pull requests
2 participants
@mattab @d-skora