New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Piwik compatible with sql_mode = STRICT_TRANS_TABLES (MySQL 5.6 default and best practise) #5178
Comments
Enabled the STRICT_TRANS_TABLES mode in: 316d9f4 Enabled Mysql 5.6 on CI: 20bd2e1 Fix notice: PDOException: SQLSTATE[42000]: Syntax error or access violation: 1101 BLOB/TEXT column 'additional_emails' can't have a default value in matomo-org/plugin-CustomAlerts@2a0c807 |
email_me is integer, fixes: General error: 1366 Incorrect integer value: '' for column 'email_me' at row 1 https://travis-ci.org/piwik/piwik/jobs/25436325 Set BOOLEAN column default to '0' and add schema Update script. in matomo-org/plugin-CustomAlerts@9c2b843 |
…e many failing tests.
fyi: seems it regressed a little in #8853 |
Mysql 5.6 now introduces default STRICT_TRANS_TABLES sql_mode, in the my.cnf config file.
All users installing Mysql 5.6 and older now have this enabled. It partly breaks a lot of popular open source software, including Piwik.
The goal of this ticket is to set
- mysql -e "SET GLOBAL sql_mode = 'NO_ENGINE_SUBSTITUTION,STRICT_TRANS_TABLES'"
in https://github.com/piwik/piwik/blob/master/plugins/CoreConsole/templates/travis.yml.twig
and make all tests pass.
eg.
The text was updated successfully, but these errors were encountered: