-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
archive.php compatibility with hhvm #5263
Comments
The reason for the -q is because some systems incorrectly use php-cgi (either directly or indirectly, e.g., by symlink). |
In zend emulation mode, hhvm will ignore unknown options. There are two ways to get into zend emulation mode, either:
Perhaps change CliMulti.php's findBinary method to use something like:
|
@voidswitch Thanks for the report! could you please try the change suggested by Anthon, and check it works for you on HHVM without your other patch? |
hi, after vacation I changed
to the implementation suggested by Anthon, and undid the '-q' change. So far it works. Processlist now shows
Edit: |
WE will look forward to your feedback, and hopefully make Piwik work well with HHVM for all users :-) This ticket is a "sub-task" of #4415 Test if Piwik runs with HipHop Virtual Machine |
I am still getting issues with running the archive using the console, removing the
I made small edits to
This edit retains backwards compatibility previously used with PHP while allowing HHVM compatibility when |
We are tracking 24 sites with piwik, with about 1 million page views per day. Once a day we run archive.php, which runs significant faster with hhvm (Currently about 30 min).
However, there is one compatibility change in piwik/core/CliMulti.php we need to do every time an update to piwik is deployed.
piwik/core/CliMulti.php uses the commandline switch '-q' for building the command to execute (Line 108 in piwik/core/CliMulti.php - Piwik 2.2.2), which is not supported by hhvm.
For our purpose, it's ok to remove '-q' from the command.
The text was updated successfully, but these errors were encountered: