Ticket #530 (closed New feature: fixed)

Opened 3 years ago

Last modified 2 years ago

Report actions by html page title as well as reporting by URL (or custom page name)

Reported by: matt Owned by:
Priority: critical Milestone: Piwik 0.5
Component: Core Keywords:
Cc: Sensitive: no

Description (last modified by matt) (diff)

Currently Piwik reports on pages URL structures, or if user specifies a custom action name in the javascript, Piwik reports on this custom name. Piwik has always access to the html page title and could build the report of the best page by title.

Therefore there would be a new API function to get the top pages by title, as well as the current method getActions to get the top actions by URL.

The title could be customized on the JS side by calling piwik.setDocumentTitle().

We would not report on best landing page, or top exit pages by title. We would not report on time per page title. These extra analysis would only be done on the URLs to minimize overhead during archiving.

Change History

Changed 3 years ago by matt

  • description modified (diff)

Changed 3 years ago by matt

  • description modified (diff)

Changed 3 years ago by vipsoft

piwik.js sends the document.title in the 'title' parameter but it is not currently used by the server. (A mod_security issue was raised in #564. We could add title_var_name to global.ini.php, in a similar manner to download_url_var_name, or we could use encodeURIComponent() in piwik.js instead of simply, escape().)

Changed 3 years ago by vipsoft

Re: previous comment. Upon closer inspection, the parameter name doesn't matter. mod_security's PHP injection rules are generic and extremely broad, e.g.,

SecRule REQUEST_FILENAME|ARGS|ARGS_NAMES

i.e., try to match against the request filename, arguments, and argument names. To address the issue requires encoding all args from client-to-server, and a review of the arg names used in Piwik to make sure they aren't on the blacklist.

Note: encodeURIComponent() doesn't have a native PHP equivalent; similarly, there's no native version of urlencode() for JavaScript.

Changed 3 years ago by matt

  • milestone changed from Stable release to DigitalVibes

Changed 3 years ago by matt

  • priority changed from major to critical

Changed 3 years ago by vipsoft

Per analysis in #564, mod_security requirements are removed from this ticket.

Changed 3 years ago by matt

  • description modified (diff)

Changed 2 years ago by domtop

Changed 2 years ago by matt

  • status changed from new to closed
  • sensitive unset
  • resolution set to fixed

fixed in [1530]

Changed 2 years ago by matt

  • milestone changed from 2- DigitalVibes to 1 - Piwik 0.5
Note: See TracTickets for help on using tickets.