Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove morpheus priority, which broke custom themes. #5345

Closed
anonymous-matomo-user opened this issue Jun 13, 2014 · 2 comments
Closed

Remove morpheus priority, which broke custom themes. #5345

anonymous-matomo-user opened this issue Jun 13, 2014 · 2 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. worksforme The issue cannot be reproduced and things work as intended.
Milestone
2.4.0

Comments

@anonymous-matomo-user
Copy link

This priority order cause that all morpheus stylesheets are loaded at very end of generated css file and custom theme rules are overwritten by morpheus.

This line cause that problem:
https://github.com/piwik/piwik/blob/master/core/AssetManager/UIAssetFetcher/StylesheetUIAssetFetcher.php#L22
@mattab
Copy link
Member

mattab commented Jun 20, 2014

See new pull request: #323

@mattab
Copy link
Member

mattab commented Jul 1, 2014

discussed in pull request

@anonymous-matomo-user anonymous-matomo-user added this to the 2.4.0 - Piwik 2.4.0 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. worksforme The issue cannot be reproduced and things work as intended.
Projects
None yet
Milestone
2.4.0
Development

No branches or pull requests
2 participants
@mattab @anonymous-matomo-user