New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Row evolution data export fails when filter_limit is supplied #5397
Comments
It seems to affect pages URLs that contain a comma character (and maybe other characters are affected?) |
There's also another issue - filter_limit being applied before label filter. Here one example from demo.piwik.org: That's the default one - row evolution report export. And here with disabled filter_limit: |
@ kuba.cc suggestion seems to be the actual issue see ResponseBuilder. I'm gonna try to move the label filter upwards just to see which test fail afterwards... |
Tests fail after moving the label filter, see https://travis-ci.org/piwik/piwik/jobs/29283168 I think one problem is that "SafeDecodeLabel" ( https://github.com/piwik/piwik/blob/master/core/API/ResponseBuilder.php#L319 ) is no longer executed before the LabelFilter meaning the tests should be updated meaning we would change the API. We could recommend to always use filter_limit = -1 when a label filter is used but doesn't sound very intuitive. Especially our export links in the UI would have to take care of this as well :( A hack to always set the filter_limit to -1 when a label filter is used results in even more problems in the end. So basically to keep the API the same we'd have to "undo" the SafeDecodeLabel of the label url parameter and then compare. This could work |
Couldn't really fix it without breaking anything. Maybe someone else wants to have a look? |
Changing title since the bug is only present when a filter_limit is present. |
…lFilter: ignore filter_limit and filter_truncate when label query param used since it makes no sense to use them w/ LabelFilter.
There seems to be a bug with exporting data from row evolution for labels in action report, which have bounce rate = 100%.
Steps to reproduce:
Tasks
The text was updated successfully, but these errors were encountered: