Ticket #554 (new Bug)

Opened 3 years ago

Last modified 19 months ago

users with "view" access should see the link to display the javascript code for their sites

Reported by: matt Owned by:
Priority: normal Milestone: Feature requests
Component: Core Keywords:
Cc: Sensitive: no

Description

Users with a "view" permission should see the table with the website information and the "Show Javascript" link, the same way "admin" users currently see the table.

For users with "view", the website table wouldn't be editable.

see also #526

Attachments

patch#554.txt Download (2.5 KB) - added by sophie 22 months ago.
js.gif Download (82 bytes) - added by sophie 22 months ago.
Icon
MultiSite-extended.png Download (20.6 KB) - added by sophie 22 months ago.

Change History

Changed 2 years ago by matt

  • sensitive unset
  • milestone changed from 5 - Piwik 1.0 - Stable release to 2 - Piwik 0.6 - DigitalVibes

Changed 23 months ago by vipsoft

  • milestone changed from 2 - Piwik 0.7 - DigitalVibes to 1 - Piwik 0.6

Moving this to 0.6. Access to #42 ("exclude visits by cookie") should be incorporated into the SitesManager UI.

Changed 22 months ago by sophie

I extended the MultiSites-Controller table by a new Icon, linked to the javascript code of the site. For displaying the javascrit code, i utilize the existing SitesManager module. For non-Admin user i disable the SitesManager-Navigation. See attached Screenshot and patch.

Would this an adequate solution for this ticket?

Changed 22 months ago by sophie

Changed 22 months ago by sophie

Icon

Changed 22 months ago by sophie

Changed 22 months ago by matt

Sophie, I think it would be better to have the javascript displayed in the "website" tab for "view" users, after clicking "settings" in the top bar (available in trunk for "view" users)

Changed 22 months ago by sophie

Ok, i see.

So it's changing #526:

"- for user with 'view', only show the "My Profile" tab"

to

"- for user with 'view', show the "My Profile" and "Websites" tab".

Right?

There are two further questions for me:

1. For the view-only user the table's content it's clear: "For users with "view", the website table wouldn't be editable." But I can't find anything about the editing by an admin user. Currently it's behaving strange (Edit is clickable, just site name is changeable, but changes can't be saved). How should the table editing/deleting behave for an admin user?

2. I assume: For multi sites a user can have view access to one site as well as admin access to another site. Am i right? If yes: Should view and admin sites mixed into one table? Or do you like to provide seperate tables? Shurely it depends whether the interaction of view and admin user will be different or not. If not, the sites could simply shown in one table.

Changed 22 months ago by matt

I think that it could be like:

  • view users "Websites" tab shows the table of websites, with rows that are not editable
  • admin users' "Websites" tab is the same behavior as current Websites tab (editable website table).

If the edit website screen does not work for you, it is a bug in Piwik. It works for us in 0.5.5 and 0.6-rc1 (edit name / URLs / etc. and click the green button to update).

There is no difference in how view or admin websites are handled in all the web analytics reports: they behave exactly the same.

Changed 21 months ago by vipsoft

  • priority changed from major to normal

Changed 19 months ago by matt

  • milestone changed from 0 - Piwik 0.6.4 to Features requests - after Piwik 1.0
Note: See TracTickets for help on using tickets.