Opened 5 years ago

Closed 5 years ago

#591 closed Bug (fixed)

VisitsSummary index does not properly translate time period

Reported by: trinta Owned by:
Priority: low Milestone: RobotRock
Component: Plugins Wishlist Keywords:
Cc: Sensitive:

Description

The title on the VisitsSummary::index() -page is not properly translated. In /plugings/VisitsSummary/Controller.php the function index() contains the following:

$currentPeriod = Piwik_Common::getRequestVar('period');
$view->period = $currentPeriod;

and the translation string in the template (VisitsSummary_Evolution) is:

'VisitsSummary_Evolution' => 'Evolution on the last 30 %ss',

This does not work for other languages than English because:
1) The $period is not translated
2) This assumes that plural version of the time period can be conjugated by just adding a letter

The period should be translated, and this means that actually new translation items must be added for day, month and year for this context.

Change History (2)

comment:1 Changed 5 years ago by matt (mattab)

  • Milestone changed from Stable release to RobotRock

comment:2 Changed 5 years ago by matt (mattab)

  • Resolution set to fixed
  • Status changed from new to closed

fixed in [977]

Note: See TracTickets for help on using tickets.