Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VisitsSummary index does not properly translate time period #591

Closed
anonymous-matomo-user opened this issue Mar 9, 2009 · 1 comment
Closed
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@anonymous-matomo-user
Copy link

The title on the VisitsSummary::index() -page is not properly translated. In /plugings/VisitsSummary/Controller.php the function index() contains the following:

```
$currentPeriod = Piwik_Common::getRequestVar(‘period’);
$view→period = $currentPeriod;
```

and the translation string in the template (VisitsSummary_Evolution) is:

```
‘VisitsSummary_Evolution’ => ‘Evolution on the last 30 %ss’,
```

This does not work for other languages than English because:
1) The $period is not translated
2) This assumes that plural version of the time period can be conjugated by just adding a letter

The period should be translated, and this means that actually new translation items must be added for day, month and year for this context.

@mattab
Copy link
Member

mattab commented Mar 9, 2009

fixed in 977

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

2 participants