Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should use click event instead of mousedown #661

Closed
anonymous-matomo-user opened this issue Apr 15, 2009 · 3 comments
Closed

should use click event instead of mousedown #661

anonymous-matomo-user opened this issue Apr 15, 2009 · 3 comments
Assignees
@robocoder
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone
0.4

Comments

@anonymous-matomo-user
Copy link

Piwik click tracking should use the click event instead of the mousedown event because:

1.) mousedown is not the same as a click and it should be tracking clicks.

2.) The current way of doing things prevents the right-click menu from appearing until the tracking code has run, which can take a long time for downloads or external links.
@robocoder
Copy link
Contributor

Yes, this is inconsistent from the GA, MS, and Y! tracking code.

While this is already moot in the new piwik.js under development — the delay is deferred to the unload — I will change this to be consistent with other trackers.

@robocoder
Copy link
Contributor

(In [1151]) fixes #5775 - OO version of piwik.js which no longer modifies DOM;
remove misc/testJavascripTracker (interactive tests);
add tests/javascript (QUnit unit tests);
fixes #661 - use click event instead of mousedown;
fixes #549 - define your own download/outlink tracking classes;
fixes #5502 - add hook interface for module

@mattab
Copy link
Member

mattab commented Jun 3, 2014

See #5287 track file download and outlinks when user opens URL with Right click (opens new tab)

@anonymous-matomo-user anonymous-matomo-user added this to the Piwik 0.4 milestone Jul 8, 2014
@mattab mattab mentioned this issue Jun 5, 2014
Closed
This was referenced May 28, 2009
Closed
Closed
@mattab mattab closed this as not planned Won't fix, can't repro, duplicate, stale Jan 3, 2024
@sgiehl sgiehl modified the milestones: For Prioritization, 0.4 Jan 3, 2024
@sgiehl sgiehl closed this as not planned Won't fix, can't repro, duplicate, stale Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robocoder robocoder

Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
5 participants
@mattab @robocoder @sgiehl @anonymous-matomo-user @innocraft-automation