Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a check for ZLIB extension at install #700

Closed
mattab opened this issue May 11, 2009 · 19 comments
Closed

add a check for ZLIB extension at install #700

mattab opened this issue May 11, 2009 · 19 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone

Comments

@mattab
Copy link
Member

mattab commented May 11, 2009

currently we don't check that the user has the zlib extension, but it is required for piwik to work correctly. We should add this check at installation.

@pebosi
Copy link
Contributor

pebosi commented May 25, 2009

added a patch to check extensions array for zlib.

@pebosi
Copy link
Contributor

pebosi commented May 25, 2009

Attachment:
700_check_zlib.patch

@pebosi
Copy link
Contributor

pebosi commented May 25, 2009

i created another patch to reduce some code, only a suggestion... (if useful i will modify template too)

regards

@pebosi
Copy link
Contributor

pebosi commented May 25, 2009

Attachment:
700_systemcheck.patch

@robocoder
Copy link
Contributor

pebosi: it looks good with the exception of the changes from lines 488-499. It looks like the version requirement has been reversed; meanwhile, there's no check when the gd extension is missing.

@pebosi
Copy link
Contributor

pebosi commented May 28, 2009

my last patch also removes traling spaces...

@mattab
Copy link
Member Author

mattab commented May 29, 2009

pebosi, your patch is hard to read as you removed all white spaces etc.
can you please submit patch against trunk for only the lines you modified?

@pebosi
Copy link
Contributor

pebosi commented May 29, 2009

Attachment: next try
700_gd_systemcheck.patch

@pebosi
Copy link
Contributor

pebosi commented May 29, 2009

added patch version without removing whitespaces

@mattab
Copy link
Member Author

mattab commented May 30, 2009

assuming it has been tested, looks good to me

@mattab
Copy link
Member Author

mattab commented May 30, 2009

actually we should also add SPL to the list of required extension as of #176

@pebosi
Copy link
Contributor

pebosi commented May 30, 2009

Attachment: added spl check
700_spl_systemcheck.patch

@robocoder
Copy link
Contributor

Looks good (except for some minor formatting). Can you update the systemCheck template too and test it?

@pebosi
Copy link
Contributor

pebosi commented Jun 2, 2009

Attachment: updated patch
700_spl_systemcheck.2.patch

@pebosi
Copy link
Contributor

pebosi commented Jun 2, 2009

Attachment: updated template file, no patch
systemCheck.tpl

@pebosi
Copy link
Contributor

pebosi commented Jun 2, 2009

attached an updated patch and the first version of tempalte file (no patch). i replaced the help text of gd and extension-check with a link to http://piwik.org/docs/requirements/ (needs to be updated then)... only a suggestion ;)

regards

@pebosi
Copy link
Contributor

pebosi commented Jun 2, 2009

Attachment: patch for template file
700_systemcheck_template.patch

@robocoder
Copy link
Contributor

Sorry for not reviewing this sooner.

  • Controller.php: ereg should be replaced with preg_match() for php 5.3
  • systemCheck.tpl: one link to http://piwik.org/docs/requirements/ should be sufficient
  • lang/en.php needs to be updated

We should add/keep the informative help messages (e.g., Installation_SystemCheckPdoHelp). Perhaps:

$needed_functions = array(
    'set_time_limit' => 'Installation_SystemCheckTimeLimitHelp',
    'mail'           => 'Installation_SystemCheckMailHelp',
);

@robocoder
Copy link
Contributor

(In [1368]) fixes #700 - added check for zlib and SPL at install; based on pebosi's patch

@mattab mattab added this to the Piwik 0.4.3 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

3 participants