Wordpress CSS bug

[black silence]

The piwik.org wordpress stylesheet does not define a background color. Patch attached, please fix.

[black silence]

Screenshot of problem

[vipsoft]

I think you need to pass this along to the WP plugin author.

Piwik does set the background colour in themes/default/simple_structure.css

[feyp]

vipsoft: This is not about the WP plugin and not about Piwiki. This is about the piwik.org website (see the screenshot).

[vipsoft]

sorry too early in the a.m.

what browser are you using?

[feyp]

No problem.

I'm not the reporter of the bug, but you can reproduce the bug in any browser. Just set the default background colour to something else than white. The patch provided by the reporter will fix the problem by setting white as the background colour of the page in addition to the background image.

[vipsoft]

that sounds counter intuitive... if the user has changed the default background color in their browser config, isn't the right approach to respect that (even if it looks bad)?

[feyp]

Yes, you should respect the default settings of the browser. But: If you set a foreground colour (i.e. text colour) you need to set the background colour, too.

Suppose one likes white text on black background. While not everyone's taste, you can still read it. So if a web page does not set either background colour or foreground colour, you're fine with this default setting. Now consider this: A web page does not set background colour, but sets text colour to black. You end up with black text on black background. The result: Unreadable.

Piwik.org sets a foreground colour. That's why it should set a sensible background-colour, too.

[black silence]

Comment 6 by feyp is absolutely right. If you define one colour (text or background) you have to define the other too or bad things may happen, see the screenshot for an example.

This is a common problem all over the internet, but only few people (like me) notice it.

[matt]

fixed http://piwik.org/blog/wp-content/themes/wp-inspirat/style.css as patch by black silence

[black silence]

nice, thanks very much