Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wordpress CSS bug #726

Closed
anonymous-matomo-user opened this issue May 16, 2009 · 11 comments
Closed

Wordpress CSS bug #726

anonymous-matomo-user opened this issue May 16, 2009 · 11 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Website matomo.org For issues related to our matomo.org website. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.

Comments

@anonymous-matomo-user
Copy link

The piwik.org wordpress stylesheet does not define a background color. Patch attached, please fix.

@anonymous-matomo-user
Copy link
Author

Attachment:
style.patch

@anonymous-matomo-user
Copy link
Author

Attachment: Screenshot of problem
screenshot8.png

@robocoder
Copy link
Contributor

I think you need to pass this along to the WP plugin author.

Piwik does set the background colour in themes/default/simple_structure.css

@anonymous-matomo-user
Copy link
Author

vipsoft: This is not about the WP plugin and not about Piwiki. This is about the piwik.org website (see the screenshot).

@robocoder
Copy link
Contributor

sorry too early in the a.m.

what browser are you using?

@anonymous-matomo-user
Copy link
Author

No problem.

I'm not the reporter of the bug, but you can reproduce the bug in any browser. Just set the default background colour to something else than white. The patch provided by the reporter will fix the problem by setting white as the background colour of the page in addition to the background image.

@robocoder
Copy link
Contributor

that sounds counter intuitive... if the user has changed the default background color in their browser config, isn't the right approach to respect that (even if it looks bad)?

@anonymous-matomo-user
Copy link
Author

Yes, you should respect the default settings of the browser. But: If you set a foreground colour (i.e. text colour) you need to set the background colour, too.

Suppose one likes white text on black background. While not everyone's taste, you can still read it. So if a web page does not set either background colour or foreground colour, you're fine with this default setting.
Now consider this: A web page does not set background colour, but sets text colour to black. You end up with black text on black background. The result: Unreadable.

Piwik.org sets a foreground colour. That's why it should set a sensible background-colour, too.

@anonymous-matomo-user
Copy link
Author

Comment 6 by feyp is absolutely right. If you define one colour (text or background) you have to define the other too or bad things may happen, see the screenshot for an example.

This is a common problem all over the internet, but only few people (like me) notice it.

@mattab
Copy link
Member

mattab commented May 18, 2009

fixed http://piwik.org/blog/wp-content/themes/wp-inspirat/style.css as patch by black silence

@anonymous-matomo-user
Copy link
Author

nice, thanks very much

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Website matomo.org For issues related to our matomo.org website. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

4 participants