Tracker memory leak: out of memory with default settings

[black silence]

Bulk loading (eg via the VisitorGenerator) is hampered by a memory leak in the tracker. This is a blocker for #134.

The original bug report below:

I get an out-of-memory error when I try to use the misc/generateVisits.php with default settings that comes with Piwik - tested on localhost with a memory limit of 128M

Maybe the default values should be lower than 20k visits. 200 visits work for me and I can run the generator multiple times if I need more :)

Lowering the number of visits generated is a quick fix and makes the generator usable for new users who want to try Piwik.

"Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 71 bytes) in piwik/core/Common.php on line 662

[vipsoft]

Is this fixed by [1145] and [1148] ?

[black silence]

Sorry, but no. The only thing that changes is the line number.

Used r1153 with default settings in generateVisits.php for testing.

Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 71 bytes) in piwik/core/Common.php on line 647

[matt]

I remember tryign to identify where the generator was leaking but couldn't pin point it; if you can find it it would be great..

[vipsoft]

(In [1299]) refs #803, refs #735 - lower default to 200; remove unnecessary require_once; standardize setting of include_path

[vipsoft]

(In [1305]) refs #735 - simplify structure of DataFiles/Countries.php

[vipsoft]

It looks like there is a leak in Piwik_Tracker_Db's fetch(). The fix may be non-trivial since PDO doesn't have a free_result() method like MySQLi.

[vipsoft]

Deferring to next milestone where Generator refactoring and server-side tracking API plugin being worked on.