Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize include path #743

Closed
robocoder opened this issue May 26, 2009 · 5 comments
Closed

Optimize include path #743

robocoder opened this issue May 26, 2009 · 5 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@robocoder
Copy link
Contributor

At present, index.php and piwik.php set the include path (relative to the Piwik document root) to: /, /core, /libs, /plugins, plus the existing include path.

The proposal here is to remove / from the above class search path as it is a frequent "miss". The handful of references to /config, /lang, and /misc can be converted to absolute paths.

@robocoder
Copy link
Contributor Author

Attachment:
743.diffs

@robocoder
Copy link
Contributor Author

Proposed patch attached.

@robocoder
Copy link
Contributor Author

(In [1150]) fixes #743 - optimize include path; refs #631

@robocoder
Copy link
Contributor Author

(In [1153]) refs #743 - fix dependencies

@mattab
Copy link
Member

mattab commented Jun 1, 2009

(In [1164]) - refs #743 fixing for tests as well

@robocoder robocoder added this to the Piwik 0.4 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

2 participants