You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
mattab opened this issue
May 27, 2009
· 7 comments
Labels
BugFor errors / faults / flaws / inconsistencies etc.MajorIndicates the severity or impact or benefit of an issue is much higher than normal but not critical.
>
> Piwik removes url path section which contains 0, e.g.
>
> portal/ategories/223/1/0/1/company/3107
>
> is recorded as
>
> portal/ategories/223/1/1/company/3107
>
> in log table - which is incorrect.
see code in tracker/action and matching unit tests, need fixing
The text was updated successfully, but these errors were encountered:
Attachment 745_patch.txt appears to fix the problem by only removing empty-strings in the array_filter. This is accomplished using a filter function implemented as a static on the Piwik_Tracker_Action class (a lambda function could also be used, but I guess that would be less efficient).
Unit test tests/core/Tracker/Action.test.php has also been updated to include the given test case above. Unit test passes successfully.
Thanks. FYI "ClassName::StaticFunction" is a 5.2.x-ism for callbacks. In general, for backwards compatibility, we should be using this syntax, array('ClassName', 'StaticFunction'). However, in this specific case, I believe we can just use 'strlen' for the callback.
BugFor errors / faults / flaws / inconsistencies etc.MajorIndicates the severity or impact or benefit of an issue is much higher than normal but not critical.
from email:
see code in tracker/action and matching unit tests, need fixing
The text was updated successfully, but these errors were encountered: