Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove time() #753

Closed
pebosi opened this issue Jun 5, 2009 · 3 comments
Closed

Remove time() #753

pebosi opened this issue Jun 5, 2009 · 3 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone

Comments

@pebosi
Copy link
Contributor

pebosi commented Jun 5, 2009

I recently read the Drupal 7 changes (http://drupal.org/node/224333#time), and i thought, replacing time() calls with a constant (http://api.drupal.org/api/constant/REQUEST_TIME/7) could be a good thing for piwik too.

regards
Keywords: outofscope

@robocoder
Copy link
Contributor

Further analysis required. This may be a non-trivial peephole optimization, i.e., there is a semantic difference between the request time and "now".

@mattab
Copy link
Member

mattab commented Jun 7, 2009

agreed, please don't create tickets like this in next roadmap if there is no patch attached; that's OK if it's justified and a patch is there. thanks!

@robocoder
Copy link
Contributor

note: in php 5.4.0 alpha 1, $_SERVER['REQUEST_TIME'] was changed to include microsecond precision.

@pebosi pebosi added this to the Piwik 0.4.1 milestone Jul 8, 2014
@mattab mattab added wontfix and removed wontfix labels Aug 3, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

3 participants