Opened 5 years ago

Closed 5 years ago

#757 closed Bug (worksforme)

Syntax error in Embed Flash (widgetize)

Reported by: kaystrobach Owned by:
Priority: major Milestone: Piwik 0.4.1
Component: Core Keywords:
Cc: Sensitive:

Description

It seems, that the value of the flash export field is not escaped correctly and so the value is not completly in the input field.

Example in 0.2.37 VisitsSummary->Overview

<label for="embedThisWidgetFlashInput">› Embed Flash</label><span id="embedThisWidgetFlashInput"><input class="formEmbedCode" id="flashEmbed" value="&lt;object style=&quot;visibility: visible;&quot; id=&quot;VisitsSummarygetEvolutionGraphChart_swf&quot; data=&quot;/typo3conf/ext/piwikintegration/piwik/libs/open-flash-chart/open-flash-chart.swf&quot; bgcolor=&quot;#FFFFFF&quot; type=&quot;application/x-shockwave-flash&quot; height=&quot;150&quot; width=&quot;100%&quot;&gt;&lt;param value=&quot;sameDomain&quot; name=&quot;allowScriptAccess&quot;&gt;&lt;param value=&quot;opaque&quot; name=&quot;wmode&quot;&gt;&lt;param value=&quot;data-file=http%3A%2F%2Fwww.jrk-dresden.de%2Ftypo3conf%2Fext%2Fpiwikintegration%2Fpiwik%2Findex.php%3Fmodule%3DVisitsSummary%26action%3DgetEvolutionGraph%26columns%5B%5D%3Dnb_visits%26idSite%3D5%26period%3Dweek%26date%3D2008-11-10%2C2009-06-07%26viewDataTable%3DgenerateDataChartEvolution&amp;loading=Loading...&quot; name=&quot;flashvars&quot;&gt;&lt;/object&gt;

&lt;div id=&quot;dataTableFeatures&quot;&gt;
&lt;div&gt;
&lt;span id=&quot;dataTableFooterIcons&quot;&gt;
&lt;span id=&quot;exportToFormat&quot; style=&quot;display: none; padding-left: 4px;&quot;&gt;
&lt;span id=&quot;dataTableFooterExportAsImageIcon&quot;&gt;
&lt;a href=&quot;javascript:OFC.jquery.popup(" visitssummarygetevolutiongraphchart_swf="" );=""><img title="Export as Image" src="http://www.jrk-dresden.de/typo3conf/ext/piwikintegration/piwik/themes/default/images/image.png">
</span>
<img src="http://www.jrk-dresden.de/typo3conf/ext/piwikintegration/piwik/themes/default/images/export.png" title="Export" height="16" width="16">
<span id="linksExportToFormat" style="display: none;">
<a href="?module=API&amp;method=VisitsSummary.get&amp;format=CSV&amp;idSite=5&amp;period=week&amp;date=2008-11-10,2009-06-07&amp;token_auth=&amp;filter_limit=100" target="_blank" class="exportToFormat" methodtocall="VisitsSummary.get" format="CSV" filter_limit="100">CSV</a> |
<a href="?module=API&amp;method=VisitsSummary.get&amp;format=XML&amp;idSite=5&amp;period=week&amp;date=2008-11-10,2009-06-07&amp;token_auth=&amp;filter_limit=100" target="_blank" class="exportToFormat" methodtocall="VisitsSummary.get" format="XML" filter_limit="100">XML</a> |

<a href="?module=API&amp;method=VisitsSummary.get&amp;format=JSON&amp;idSite=5&amp;period=week&amp;date=2008-11-10,2009-06-07&amp;token_auth=&amp;filter_limit=100" target="_blank" class="exportToFormat" methodtocall="VisitsSummary.get" format="JSON" filter_limit="100">Json</a> |
<a href="?module=API&amp;method=VisitsSummary.get&amp;format=PHP&amp;idSite=5&amp;period=week&amp;date=2008-11-10,2009-06-07&amp;token_auth=&amp;filter_limit=100" target="_blank" class="exportToFormat" methodtocall="VisitsSummary.get" format="PHP" filter_limit="100">Php</a> |
<a href="?module=API&amp;method=VisitsSummary.get&amp;format=RSS&amp;idSite=5&amp;period=week&amp;date=last10&amp;token_auth=&amp;filter_limit=100" target="_blank" class="exportToFormat" methodtocall="VisitsSummary.get" format="RSS" filter_limit="100" date="last10"><img src="http://www.jrk-dresden.de/typo3conf/ext/piwikintegration/piwik/themes/default/images/feed.png" border="0"></a>
</span>

<span id="dataTableFooterIconsShow" style="padding-left: 4px;">
<img src="http://www.jrk-dresden.de/typo3conf/ext/piwikintegration/piwik/plugins/CoreHome/templates/images/more.png">
</span>

</div>
<span id="loadingDataTable"><img src="http://www.jrk-dresden.de/typo3conf/ext/piwikintegration/piwik/themes/default/images/loading-blue.gif"> Lade Daten...</span>

<div class="dataTableSpacer"></div>

' onclick="javascript:document.getElementById('flashEmbed').focus();document.getElementById('flashEmbed').select();" readonly="true" type="text"&gt

Attachments (1)

piwik.png (59.1 KB) - added by kaystrobach 5 years ago.
screenshot

Download all attachments as: .zip

Change History (2)

Changed 5 years ago by kaystrobach

screenshot

comment:1 Changed 5 years ago by vipsoft (robocoder)

  • Milestone set to 1 - Piwik 0.4.1
  • Resolution set to worksforme
  • Status changed from new to closed
  • Summary changed from Syntaxerror in to Syntax error in Embed Flash (widgetize)

Should already be fixed in 0.4RC3.

Note: See TracTickets for help on using tickets.