Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax error in Embed Flash (widgetize) #757

Closed
anonymous-matomo-user opened this issue Jun 6, 2009 · 2 comments
Closed

Syntax error in Embed Flash (widgetize) #757

anonymous-matomo-user opened this issue Jun 6, 2009 · 2 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. worksforme The issue cannot be reproduced and things work as intended.
Milestone

Comments

@anonymous-matomo-user
Copy link

It seems, that the value of the flash export field is not escaped correctly and so the value is not completly in the input field.

Example in 0.2.37 VisitsSummary->Overview

<label for="embedThisWidgetFlashInput"> Embed Flash</label><span id="embedThisWidgetFlashInput"><input class="formEmbedCode" id="flashEmbed" value="<object style="visibility: visible;" id="VisitsSummarygetEvolutionGraphChart_swf" data="/typo3conf/ext/piwikintegration/piwik/libs/open-flash-chart/open-flash-chart.swf" bgcolor="#FFFFFF" type="application/x-shockwave-flash" height="150" width="100%"><param value="sameDomain" name="allowScriptAccess"><param value="opaque" name="wmode"><param value="data-file=http%3A%2F%2Fwww.jrk-dresden.de%2Ftypo3conf%2Fext%2Fpiwikintegration%2Fpiwik%2Findex.php%3Fmodule%3DVisitsSummary%26action%3DgetEvolutionGraph%26columns%5B%5D%3Dnb_visits%26idSite%3D5%26period%3Dweek%26date%3D2008-11-10%2C2009-06-07%26viewDataTable%3DgenerateDataChartEvolution&loading=Loading..." name="flashvars"></object>

<div id="dataTableFeatures">
<div>
<span id="dataTableFooterIcons">
<span id="exportToFormat" style="display: none; padding-left: 4px;">
<span id="dataTableFooterExportAsImageIcon">
<a href="javascript:OFC.jquery.popup(" visitssummarygetevolutiongraphchart_swf="" );=""><img title="Export as Image" src="http://www.jrk-dresden.de/typo3conf/ext/piwikintegration/piwik/themes/default/images/image.png">
</span>
<img src="http://www.jrk-dresden.de/typo3conf/ext/piwikintegration/piwik/themes/default/images/export.png" title="Export" height="16" width="16">
<span id="linksExportToFormat" style="display: none;">
<a href="?module=API&method=VisitsSummary.get&format=CSV&idSite=5&period=week&date=2008-11-10,2009-06-07&token_auth=&filter_limit=100" target="_blank" class="exportToFormat" methodtocall="VisitsSummary.get" format="CSV" filter_limit="100">CSV</a> |
<a href="?module=API&method=VisitsSummary.get&format=XML&idSite=5&period=week&date=2008-11-10,2009-06-07&token_auth=&filter_limit=100" target="_blank" class="exportToFormat" methodtocall="VisitsSummary.get" format="XML" filter_limit="100">XML</a> |

<a href="?module=API&method=VisitsSummary.get&format=JSON&idSite=5&period=week&date=2008-11-10,2009-06-07&token_auth=&filter_limit=100" target="_blank" class="exportToFormat" methodtocall="VisitsSummary.get" format="JSON" filter_limit="100">Json</a> |
<a href="?module=API&method=VisitsSummary.get&format=PHP&idSite=5&period=week&date=2008-11-10,2009-06-07&token_auth=&filter_limit=100" target="_blank" class="exportToFormat" methodtocall="VisitsSummary.get" format="PHP" filter_limit="100">Php</a> |
<a href="?module=API&method=VisitsSummary.get&format=RSS&idSite=5&period=week&date=last10&token_auth=&filter_limit=100" target="_blank" class="exportToFormat" methodtocall="VisitsSummary.get" format="RSS" filter_limit="100" date="last10"><img src="http://www.jrk-dresden.de/typo3conf/ext/piwikintegration/piwik/themes/default/images/feed.png" border="0"></a>
</span>

<span id="dataTableFooterIconsShow" style="padding-left: 4px;">
<img src="http://www.jrk-dresden.de/typo3conf/ext/piwikintegration/piwik/plugins/CoreHome/templates/images/more.png">
</span>

</div>
<span id="loadingDataTable"><img src="http://www.jrk-dresden.de/typo3conf/ext/piwikintegration/piwik/themes/default/images/loading-blue.gif"> Lade Daten...</span>

<div class="dataTableSpacer"></div>

' onclick="javascript:document.getElementById('flashEmbed').focus();document.getElementById('flashEmbed').select();" readonly="true" type="text"&gt

@anonymous-matomo-user
Copy link
Author

Attachment: screenshot
piwik.png

@robocoder
Copy link
Contributor

Should already be fixed in 0.4RC3.

@anonymous-matomo-user anonymous-matomo-user added this to the Piwik 0.4.1 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. worksforme The issue cannot be reproduced and things work as intended.
Projects
None yet
Development

No branches or pull requests

2 participants