Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug the new piwik.js from Version 0.4 doesn't work with perfectlightbox #785

Closed
anonymous-matomo-user opened this issue Jun 11, 2009 · 4 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone

Comments

@anonymous-matomo-user
Copy link

Hello,

thank you for this realy good programm, it is quiet amazing.
I used version 0.2.37 and i cloud regonize no problems.
Since I use version 0.4 the perfectlightbox isnt functional in the beloved internet explorer 6, 7 and 8.....so you see my problem ;)
For technical information I use Typo3 4.2.6, Perfectlightbox extension "perfectlightbox" version 2.2.3 (an update to 2.2.4 is not the answer, I already try this)...

so, my farest workaround is to use the piwik.js from version 0.2.37.

Question:

  • can I use the older piwik.js in the new version without bigger problems?
  • is there a possibility that someone can fix the new piwik.js to fit with perfecctlightbox?
  • or is something else I can do for help or to solve the problem ?

I hope the is an answer out there ;)
Keywords: perfectlightbox typo3 piwik.js

@anonymous-matomo-user
Copy link
Author

sorry, i forgot to mention the problem.....

perfectlightbox does anything but doing what it should do....

@robocoder
Copy link
Contributor

I believe this is the same problem as reported for lightwindow.

Can you try this? Change your tracking code to load the unminified js/piwik.js; in that file, remove the "return true" from the end of the clickHandler function.

If that doesn't resolve the issue, I'll give you the code changes to lightbox.js.

@anonymous-matomo-user
Copy link
Author

AMAZING, quiet amazing :)

yes, the problem is solved realy nice of you to answer so fast

(someone how has the right permission could close this ticket)

thank you very much

@robocoder
Copy link
Contributor

(In [1211]) Fixes #785 - omit return value -- default action is implied
(accommodates IE's handling of poorly written JavaScript)

The right way to prevent the default action with multiple click
handlers:

element.onclick = function (e) {
    e = e || window.event;
    if (e.preventDefault)
        e.preventDefault();
    else
        e.returnValue = false;
    return false;
}

@anonymous-matomo-user anonymous-matomo-user added this to the Piwik 0.4.1 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

2 participants