Opened 5 years ago

Closed 5 years ago

#816 closed Bug (fixed)

small inconsistency in javascript tracking API + documentation updates

Reported by: matt Owned by: matt
Priority: major Milestone: Piwik 0.4.2
Component: Core Keywords:
Cc: Sensitive:

Description

As documented in: http://forum.piwik.org/index.php?showtopic=1079

we would like to:

  • resolve inconsistency; probably all setX should "replace" the list of classes, except the piwik_* default css class should always be in the list.
  • update the documentation to make it a bit more clear

Thanks!

Change History (5)

comment:1 Changed 5 years ago by vipsoft (robocoder)

Should we rename the functions for consistency too?

comment:2 Changed 5 years ago by matt (mattab)

yes it sounds like a good idea. what do you think about:

  • all functions accept either array or string names, or a simple string
  • all function named setBlahClasses()
  • we keep the old functions as briges and call the new ones - for backward compatbility for 0.4 users that already use the API

comment:3 Changed 5 years ago by vipsoft (robocoder)

(In [1309]) refs #816 - added setDownloadClasses() and setLinkClasses() for consistency with setIgnoreClasses(), refactoring, and additional tests

comment:4 Changed 5 years ago by vipsoft (robocoder)

  • Owner changed from vipsoft to matt

comment:5 Changed 5 years ago by matt (mattab)

  • Resolution set to fixed
  • Status changed from new to closed

updated doc in http://piwik.org/docs/javascript-tracking/

thanks vipsoft

Note: See TracTickets for help on using tickets.