Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small inconsistency in javascript tracking API + documentation updates #816

Closed
mattab opened this issue Jun 19, 2009 · 5 comments
Closed
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Jun 19, 2009

As documented in: http://forum.piwik.org/index.php?showtopic=1079

we would like to:

  • resolve inconsistency; probably all setX should "replace" the list of classes, except the piwik_* default css class should always be in the list.
  • update the documentation to make it a bit more clear

Thanks!

@robocoder
Copy link
Contributor

Should we rename the functions for consistency too?

@mattab
Copy link
Member Author

mattab commented Jun 19, 2009

yes it sounds like a good idea. what do you think about:

  • all functions accept either array or string names, or a simple string
  • all function named setBlahClasses()
  • we keep the old functions as briges and call the new ones - for backward compatbility for 0.4 users that already use the API

@robocoder
Copy link
Contributor

(In [1309]) refs #816 - added setDownloadClasses() and setLinkClasses() for consistency with setIgnoreClasses(), refactoring, and additional tests

@robocoder
Copy link
Contributor

To do: update http://piwik.org/docs/javascript-tracking/

@mattab
Copy link
Member Author

mattab commented Jul 23, 2009

updated doc in http://piwik.org/docs/javascript-tracking/

thanks vipsoft

@mattab mattab added this to the Piwik 0.4.2 milestone Jul 8, 2014
@mattab mattab self-assigned this Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

2 participants