Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to define multiple paths in SearchEngines.php #827

Closed
anonymous-matomo-user opened this issue Jun 25, 2009 · 1 comment
Closed

Unable to define multiple paths in SearchEngines.php #827

anonymous-matomo-user opened this issue Jun 25, 2009 · 1 comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Milestone

Comments

@anonymous-matomo-user
Copy link

If an entry in SearchEngines.php has multiple keyword parameters, this can be done by putting them into an array. But the path to the search engines result page only allows one uri what could lead to search engine results without any hits.

Proposal:
Allow an array as third parameter.

Example:
'www.allesklar.de' => array('Allesklar', array('words', 'cat_path'), array('s.php?words={k}', 'l.php?cat_path={k}'), 'utf-8'),

One other suggestion for SearchEngine.php
It might bring a slight performange increase when replacing all double quotes with single quotes (http://www.php.net/manual/en/function.print.php#66392).

@robocoder
Copy link
Contributor

The third parameter would only be useful if Piwik knew which path the keyword originated from. Piwik doesn't currently try to match the path in the urlref or store it. To do so would slow down the tracker.

The performance increase replacing double quotes with single quotes is negligible. Referring to the quoted benchmarks... take the difference between any two timings and divide by 160000 iterations. For example, (3937 ms - 1179 ms)/160000 is 0.0000172375 s or roughly 17 microseconds.

@anonymous-matomo-user anonymous-matomo-user added this to the Piwik 0.4.2 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Development

No branches or pull requests

2 participants