Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 5.3 is throwing some notices #843

Closed
halfdan opened this issue Jun 30, 2009 · 4 comments
Closed

PHP 5.3 is throwing some notices #843

halfdan opened this issue Jun 30, 2009 · 4 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@halfdan
Copy link
Member

halfdan commented Jun 30, 2009

I've just compiled PHP 5.3 and took a closer look at my log. I found the following notices/warnings:

23:13:59 PHP Warning: syntax error, unexpected $end, expecting TC_DOLLAR_CURLY or TC_QUOTED_STRING or '"' in /var/www/htdocs/piwik.c0demonkey.com/html/config/global.ini.php on line 145
in /var/www/htdocs/piwik.c0demonkey.com/html/core/Tracker/Config.php on line 62
23:13:59 PHP Notice: Undefined index: record_statistics in /var/www/htdocs/piwik.c0demonkey.com/html/core/Tracker.php on line 304
23:13:59 PHP Notice: Undefined index: download_url_var_name in /var/www/htdocs/piwik.c0demonkey.com/html/core/Tracker.php on line 265
23:13:59 PHP Notice: Undefined index: outlink_url_var_name in /var/www/htdocs/piwik.c0demonkey.com/html/core/Tracker.php on line 280
23:13:59 PHP Notice: Undefined index: download_url_var_name in /var/www/htdocs/piwik.c0demonkey.com/html/core/Tracker.php on line 265
23:13:59 PHP Notice: Undefined index: outlink_url_var_name in /var/www/htdocs/piwik.c0demonkey.com/html/core/Tracker.php on line 280

As they should be easy to fix I selected the Milestone Piwik 0.4.2
Keywords: php notices

@robocoder
Copy link
Contributor

Can you please provide a patch?

@halfdan
Copy link
Member Author

halfdan commented Jul 1, 2009

Found out it's only a small adjustment in core/Tracker/Config.php.

Replace:

return $section

in __get($name) with

return count($section) > 0 ? $section : null;

@halfdan
Copy link
Member Author

halfdan commented Jul 1, 2009

Attachment: diff patch
Config.diff

@robocoder
Copy link
Contributor

(In [1265]) Fixes #843 - PHP 5.3 throwing some notices; patch from halfdan; thanks

@halfdan halfdan added this to the Piwik 0.4.2 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

2 participants