Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsorted table view in Length of Visits (patch included) #892

Closed
kurakin opened this issue Jul 31, 2009 · 3 comments
Closed

Unsorted table view in Length of Visits (patch included) #892

kurakin opened this issue Jul 31, 2009 · 3 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
0.4.3

Comments

@kurakin
Copy link

kurakin commented Jul 31, 2009

We have unsorted data in normal table view of Lenght of Visits for now. This looks slightly strange: see before.png attachment.

This simple patch solves the problem (see after.png attachment).

diff -Ebur piwik-4.2.orig/plugins/VisitorInterest/Controller.php piwik-4.2/plugins/VisitorInterest/Controller.php
--- piwik-4.2.orig/plugins/VisitorInterest/Controller.php   2009-07-08 08:19:14 +0400
+++ piwik-4.2/plugins/VisitorInterest/Controller.php    2009-07-31 20:59:21 +0400
@@ -25,6 +25,7 @@
        $view->init( $this->pluginName,  __FUNCTION__, "VisitorInterest.getNumberOfVisitsPerVisitDuration" );

        $view->setColumnsToDisplay( array('label','nb_visits') );
+       $view->setSortedColumn( 'label', 'asc' );
        $view->setColumnTranslation('label', Piwik_Translate('VisitorInterest_ColumnVisitDuration'));
        $view->disableSort();
        $view->disableExcludeLowPopulation();
@kurakin
Copy link
Author

kurakin commented Jul 31, 2009

Attachment: Unsorted Length of Visits / table view
before.png

@kurakin
Copy link
Author

kurakin commented Jul 31, 2009

Attachment: Length of Visits / table view, sorted by label
after.png

@robocoder
Copy link
Contributor

(In [1345]) fixes #892 - sort Length of Visits by label; thanks kurakin

@kurakin kurakin added this to the Piwik 0.4.3 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
0.4.3
Development

No branches or pull requests
2 participants
@robocoder @kurakin