Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit test should not access live database #897

Closed
robocoder opened this issue Aug 3, 2009 · 3 comments
Closed

unit test should not access live database #897

robocoder opened this issue Aug 3, 2009 · 3 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@robocoder
Copy link
Contributor

This is not normally a problem for most users since releases do not include the unit tests.

For the benefit of developers, however...

While fixing #896, I noticed version_core in my live database got munged. When I revisited the dashboard, it prompted a database upgrade (from 0.2.9).

@robocoder
Copy link
Contributor Author

Munging of piwik_option table doesn't appear to be reproduceable after #896.

However, API/DocumentationGenerator.test.php continues to access the live database. If possible, this should be changed.

@robocoder
Copy link
Contributor Author

This just bothered me too much...

@robocoder
Copy link
Contributor Author

(In [1360]) fixes #897 - unit tests should not access live database

@robocoder robocoder added this to the Piwik 0.4.3 milestone Jul 8, 2014
@robocoder robocoder self-assigned this Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

1 participant