Opened 5 years ago

Closed 4 years ago

#905 closed Bug (fixed)

Avoid linebreaks within the labels in some Tag Clouds (patch included)

Reported by: kurakin Owned by:
Priority: normal Milestone: Piwik 0.5
Component: UI - UX (AngularJS, twig, less) Keywords:
Cc: Sensitive: no

Description

I think, we should avoid of line breaks within the labels in some (not all) Tag Clouds views, especially in tables "Length of Visit" and "Pages per Visit". In the same time, line breaks within the labels in other Tag Cloud tables, such as "Visitor Browsers", "List of Keywords" and so on, should be allowed.

The proposed patch implements this behavior, offering the new table view property dont_break_labels. See before.png and after.png snapshots.

Take attention: this patch also offers little cosmetic improvement -- corrected line align in Tag Cloud. Left indents of lines are equal now (see snapshots).

Attachments (3)

PiwikAvoidLinebreak.patch (3.3 KB) - added by kurakin 5 years ago.
Avoid linebreaks within the labels in Length of Visit and Pages per Visit tag clouds, plus a little cosmetic change
before.png (10.6 KB) - added by kurakin 5 years ago.
after.png (10.6 KB) - added by kurakin 5 years ago.

Download all attachments as: .zip

Change History (11)

Changed 5 years ago by kurakin

Avoid linebreaks within the labels in Length of Visit and Pages per Visit tag clouds, plus a little cosmetic change

Changed 5 years ago by kurakin

Changed 5 years ago by kurakin

comment:1 Changed 5 years ago by vipsoft (robocoder)

  • Milestone changed from 2- DigitalVibes to 1 - Piwik 0.4.4
  • Sensitive unset

comment:2 follow-up: Changed 5 years ago by pebosi

i think the additional function "disallowLabelsBreak" could be unattended. just do it with css.

comment:3 in reply to: ↑ 2 Changed 5 years ago by kurakin

Replying to pebosi:

i think the additional function "disallowLabelsBreak" could be unattended. just do it with css.

I need to disallow linebreaks for two tables only: "Length of Visit" and "Pages per Visit". Linebreaks in all other tables should stay allowed. So I propose new property "dont_break_labels" to disable linebreaks selectively.

Thereto, disallowed linebreaks table can appears on the same page (dashboard) with allowed linebreaks table. These shouldn't affect each other. I don't no, how to solve it with pure css.

comment:4 follow-up: Changed 5 years ago by vipsoft (robocoder)

Would it be bad if we used the nowrap for all tag clouds?

comment:5 in reply to: ↑ 4 Changed 5 years ago by kurakin

Replying to vipsoft:

Would it be bad if we used the nowrap for all tag clouds?

It should be good enough for me at this time (I tried this about 3 mounths ago).

However, the original solution proposed in this ticket is just little more flexible. Who knows... may be in the future Piwik will have the tables with very long labels, requiring linebreaks anyway...

Though, at this time the simple solution -- nowrap for all tag clouds -- is satisfying for me too.

Thankee for your attention.

comment:6 Changed 5 years ago by vipsoft (robocoder)

  • Milestone changed from 1 - Piwik 0.4.4 to 2 - Piwik 0.5

tackle in conjunction with #946

comment:7 Changed 4 years ago by vipsoft (robocoder)

  • Component changed from Core to UI (templates, javascript)
  • Priority changed from low to normal

comment:8 Changed 4 years ago by vipsoft (robocoder)

  • Resolution set to fixed
  • Status changed from new to closed

In [1567], fixes #905 - apply css changes

Note: See TracTickets for help on using tickets.