New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid linebreaks within the labels in some Tag Clouds (patch included) #905
Comments
Attachment: Avoid linebreaks within the labels in Length of Visit and Pages per Visit tag clouds, plus a little cosmetic change |
Attachment: |
Attachment: |
i think the additional function "disallowLabelsBreak" could be unattended. just do it with css. |
Replying to pebosi:
I need to disallow linebreaks for two tables only: "Length of Visit" and "Pages per Visit". Linebreaks in all other tables should stay allowed. So I propose new property "dont_break_labels" to disable linebreaks selectively. Thereto, disallowed linebreaks table can appears on the same page (dashboard) with allowed linebreaks table. These shouldn't affect each other. I don't no, how to solve it with pure css. |
Would it be bad if we used the nowrap for all tag clouds? |
Replying to vipsoft:
It should be good enough for me at this time (I tried this about 3 mounths ago). However, the original solution proposed in this ticket is just little more flexible. Who knows... may be in the future Piwik will have the tables with very long labels, requiring linebreaks anyway... Though, at this time the simple solution -- nowrap for all tag clouds -- is satisfying for me too. Thankee for your attention. |
tackle in conjunction with #946 |
In [1567], fixes #905 - apply css changes |
I think, we should avoid of line breaks within the labels in some (not all) Tag Clouds views, especially in tables "Length of Visit" and "Pages per Visit". In the same time, line breaks within the labels in other Tag Cloud tables, such as "Visitor Browsers", "List of Keywords" and so on, should be allowed.
The proposed patch implements this behavior, offering the new table view property dont_break_labels. See before.png and after.png snapshots.
Take attention: this patch also offers little cosmetic improvement -- corrected line align in Tag Cloud. Left indents of lines are equal now (see snapshots).
The text was updated successfully, but these errors were encountered: