Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modifier.escape.php - char_set? #909

Closed
robocoder opened this issue Aug 8, 2009 · 2 comments
Closed

modifier.escape.php - char_set? #909

robocoder opened this issue Aug 8, 2009 · 2 comments
Assignees
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone

Comments

@robocoder
Copy link
Contributor

The default char_set is ISO-8859-1. (Piwik does not currently specify/override this.)

Review usage of core/SmartyPlugins/modifier.escape.php. Force 'UTF-8' where necessary.

@robocoder
Copy link
Contributor Author

ISO-8859-1 is 8-bit. UTF-8 multi-byte sequences have the high bit set. HTML special chars are in the ASCII (7-bit) range. So, it's not a problem.

However, in the review, found CorePluginsAdmin used the escape modifier on the plugin description. This causes anchor tags to not display properly.

@robocoder
Copy link
Contributor Author

In [1379], don't use escape modifier when displaying plugin description.

@robocoder robocoder added this to the Piwik 0.4.3 milestone Jul 8, 2014
@robocoder robocoder self-assigned this Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

No branches or pull requests

1 participant