Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Export as Image" redirects to a page without character encoding declaration #926

Closed
jpfleury opened this issue Aug 12, 2009 · 3 comments
Closed

"Export as Image" redirects to a page without character encoding declaration #926

jpfleury opened this issue Aug 12, 2009 · 3 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
0.4.4

Comments

@jpfleury
Copy link

When we export a graph as an image, the page to which we are redirected doesn't contain any encoding declaration, so it can have some character encoding bugs, among other things with French sentences. For example:

<HTML>
<head>
<title>
Exporter au format Image
</title>
</head>
<body>
  <img title="Piwik Graph" src="data:image/[...]">
  <br>
  <br>
<p>
Pour enregistrer l'image sur votre ordinateur, faites un clic droit sur l'image et slectionnez "Enregistrer l'image sous..."
</p>
</body>
</html>

We should have at least a doctype and an encoding declaration. Example:

<!DOCTYPE HTML PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd ">
<HTML xmlns="http://www.w3.org/1999/xhtml">
<head>
<title>
Exporter au format Image
</title>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
  <img title="Piwik Graph" src="data:image/[...]">
  <br>
  <br>
<p>
Pour enregistrer l'image sur votre ordinateur, faites un clic droit sur l'image et slectionnez "Enregistrer l'image sous..."
</p>
</body>
</html>
@pebosi
Copy link
Contributor

pebosi commented Aug 13, 2009

Attachment: Created a little patch to add your proposals
piwik-926.patch

@robocoder
Copy link
Contributor

In [1399], fixes #926 - add encoding to generated 'Export as image' page

@robocoder
Copy link
Contributor

I introduced a regression. Fixed in [and 1406.

@jpfleury jpfleury added this to the Piwik 0.4.4 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
0.4.4
Development

No branches or pull requests
3 participants
@pebosi @jpfleury @robocoder