Opened 5 years ago

Closed 5 years ago

#939 closed Bug (fixed)

Refactor saveLanguage from Installation and CoreUpdater controllers

Reported by: vipsoft Owned by: vipsoft
Priority: low Milestone: Piwik 0.4.4
Component: Core Keywords:
Cc: Sensitive: no

Description

In #759 and #937, the language selector posts to module=LanguagesManager, which appears odd if/when it appears in the address bar.

The selector's form action should depend on the context or be configurable.

Change History (3)

comment:1 Changed 5 years ago by vipsoft (robocoder)

  • Milestone changed from 4- Stable release to 1 - Piwik 0.4.4

comment:2 Changed 5 years ago by matt (mattab)

Just to confirm, all the logic to deal with saving preferred language in session, etc. shoudl be done inside the API (and other modules should be able to statically call this API method in php)

comment:3 Changed 5 years ago by vipsoft (robocoder)

  • Resolution set to fixed
  • Status changed from new to closed

In [1408], fixes #939 - refactor saveLanguage() from Installation and CoreUpdater controllers

Added Piwik_LanguagesManager_API::getLanguageForSession() and setLanguageForSession()

Note: See TracTickets for help on using tickets.