Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timestamp in log files should appear before the message #944

Closed
anush opened this issue Aug 21, 2009 · 4 comments
Closed

Timestamp in log files should appear before the message #944

anush opened this issue Aug 21, 2009 · 4 comments
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone
0.4.4

Comments

@anush
Copy link

anush commented Aug 21, 2009

The timestamp in all the log files (logger_message, logger_error, logger_exception) are currently place after the actual message. This is due to the fact the the Piwik_Log_Formatter_FileFormatter implodes the $event array and just writes it to the file without placing the 'timestamp' item ahead of others.

I propose putting the timestamp in front so that its easier for auditing/debugging purposes.

I've attached a patch file with my proposed change.
Keywords: logger
@anush
Copy link
Author

anush commented Aug 21, 2009

Attachment:
Log.php.patch

@mattab
Copy link
Member

mattab commented Aug 21, 2009

Appart from this suggestion, do you find the logging mechanism useful as such? would it need other features?

@anush
Copy link
Author

anush commented Aug 21, 2009

(I suppose I should have categorized this as a bug rather than a feature request -- my mistake)

I think the logging mechanism does what its supposed to do without the burden of additional feature overhead.

Although, one thing I can think of... the ability to specify a "debug" level might be nice to have so that a dev instance can log these while a prod instance wont.

@robocoder
Copy link
Contributor

In [1467], fixes #944 - Timestamp in log files should appear before the message

@anush anush added this to the Piwik 0.4.4 milestone Jul 8, 2014
@robocoder robocoder mentioned this issue Nov 27, 2009
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
0.4.4
Development

No branches or pull requests
3 participants
@anush @mattab @robocoder