Opened 5 years ago

Closed 4 years ago

#946 closed Bug (fixed)

CSS warnings, errors, and ugliness

Reported by: vipsoft Owned by:
Priority: normal Milestone: Piwik 0.5
Component: UI - UX (AngularJS, twig, less) Keywords:
Cc: Sensitive: no

Description

Firefox 3 reports errors in thickbox.css, jquery-calendar.css, common.css, and dashboard.css. (Latter two are Piwik-specific.)

Canoo webtest reports warnings/errors in: index.php, dashboard.css, thickbox.css, and jquery-calendar.css.

CoreHome embeds a <style> section in the <body> for tagclouds. This should be moved to a separate .css file, and included via <link> in the <head>. The rules also need to be tightened up a bit, e.g.,

.word a {
  text-decoration:none;
}

should be:

#tagCloud .word a {
  text-decoration:none;
}

Attachments (1)

CssErrors.txt (9.0 KB) - added by vipsoft 5 years ago.

Download all attachments as: .zip

Change History (10)

Changed 5 years ago by vipsoft (robocoder)

comment:2 Changed 4 years ago by vipsoft (robocoder)

files with embedded styles:

  • ./API/templates/listAllAPI.tpl
  • ./CoreHome/templates/cloud.tpl
  • ./Feedback/templates/index.tpl
  • ./Feedback/templates/sent.tpl
  • ./Goals/templates/form_add_goal.tpl
  • ./Goals/templates/single_goal.tpl
  • ./Installation/templates/displayJavascriptCode.tpl
  • ./Installation/templates/structure.tpl
  • ./Installation/templates/systemCheck.tpl
  • ./Live/templates/index.tpl
  • ./SitesManager/templates/DisplayJavascriptCode.tpl
  • ./SitesManager/templates/SitesManager.tpl
  • ./UsersManager/templates/UsersManager.tpl
  • ./Widgetize/templates/index.tpl

comment:3 Changed 4 years ago by vipsoft (robocoder)

In [1558], refs #510, refs #946 - remove sortable helper class (no longer used)

comment:4 Changed 4 years ago by vipsoft (robocoder)

In [1559], refs #946 - fix css errors

comment:5 Changed 4 years ago by vipsoft (robocoder)

deferring jquery-calendar.css to #680, and thickbox.css to #1029

comment:6 Changed 4 years ago by vipsoft (robocoder)

In [1560], refs #946 - plugins/API : move embedded style to external stylesheet

comment:7 Changed 4 years ago by vipsoft (robocoder)

In [1561], refs #946 - plugins/CoreHome - tag cloud css cleanup

comment:8 Changed 4 years ago by vipsoft (robocoder)

In [1562], refs #946 - cloud.css

comment:9 Changed 4 years ago by vipsoft (robocoder)

  • Resolution set to fixed
  • Status changed from new to closed

Fixed for now. Re-think the reorg for #660.

Note: See TracTickets for help on using tickets.