Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Loading data" position change not restored #950

Closed
robocoder opened this issue Aug 25, 2009 · 7 comments
Closed

"Loading data" position change not restored #950

robocoder opened this issue Aug 25, 2009 · 7 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@robocoder
Copy link
Contributor

In Actions|Outlinks, or Referers|Websites (for example), clicking on a row opens a subtable. The "Loading data" animation appears in the clicked row. However, when clicking "Next", the "Loading data" no longer appears in the table footer.

To be investigated with jquery update and documented in regression test procedures.

@robocoder
Copy link
Contributor Author

In 0.5.5:

  • On the UsersManager page, the 'Loading data' appears below the user table.
  • On the SitesManager page, the 'Loading data' appears above the site table.

@julienmoumne
Copy link
Member

On both pages, should it be below or above ?

@robocoder
Copy link
Contributor Author

re: comment:4 -- I don't think it matters (above vs below), so long as it is consistent.

@julienmoumne
Copy link
Member

Attachment:
950.patch

@julienmoumne
Copy link
Member

950.patch moves both loading and ajax success message above the user table in the users manager.

@robocoder
Copy link
Contributor Author

(In [2209]) refs #950

@robocoder
Copy link
Contributor Author

(In [2210]) fixes #950

@robocoder robocoder added this to the Piwik 0.6.2 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

2 participants