Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#995 closed New feature (fixed)

bz2 is missing from the list of downloadable files

Reported by: crain Owned by:
Priority: low Milestone: Piwik 0.4.4
Component: UI - UX (AngularJS, twig, less) Keywords:
Cc: Sensitive: no

Description

In the list of downloadable file extensions inside piwik.js one very often used extensions is missing: bz2

Extensions to be treated as download links

configDownloadExtensions = '7z|aac|arc|arj|asf|asx|avi|bin|csv|doc|exe|flv|gif|gz|gzip|hqx|jar|jpe?g|js|mp(2|3|4|e?g)|mov(ie)?|msi|msp|pdf|phps|png|ppt|qtm?|ra(m|r)?|sea|sit|tar|tgz|torrent|txt|wav|wma|wmv|wpd
xls|xml|z|zip',

Change History (5)

comment:1 Changed 5 years ago by vipsoft (robocoder)

  • Component changed from Core to UI (templates, javascript)
  • Milestone changed from 1 - Piwik 0.4.4 to 2 - Piwik 0.5
  • Priority changed from major to low
  • Type changed from Bug to New feature

Note: this is configurable via addDownloadExtensions() or setDownloadExtensions().

  • Consider adding 'bz2|tbz2' to the mix;
  • Re-visit the algorithm to make sure it's only matching on the filename and not URL parameters.

comment:3 Changed 5 years ago by vipsoft (robocoder)

In [1488], refs #995 - update Qunit

comment:4 Changed 4 years ago by vipsoft (robocoder)

  • Milestone changed from 2 - Piwik 0.6 to 1 - Piwik 0.5
  • Resolution set to fixed
  • Status changed from new to closed

In [1508], fixes #995 - add bz2 (and tbz2) to list of recognized download extensions;
fix regression in [1488], where qunit no longer defines url() helper function;
fix bug in getLinkType() where it could match an extension in url params (false positive);
fixes #1007 - workaround Opera 9.22 parse bug, replacing with new RegExp() syntax

comment:5 Changed 4 years ago by vipsoft (robocoder)

In [1555], refs #995 - also handle .bz and .tbz (e.g., still used by freebsd ports)

Note: See TracTickets for help on using tickets.