Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bz2 is missing from the list of downloadable files #995

Closed
anonymous-matomo-user opened this issue Sep 25, 2009 · 5 comments
Closed

bz2 is missing from the list of downloadable files #995

anonymous-matomo-user opened this issue Sep 25, 2009 · 5 comments
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone

Comments

@anonymous-matomo-user
Copy link

In the list of downloadable file extensions inside piwik.js one very often used extensions is missing: bz2

// Extensions to be treated as download links
configDownloadExtensions = '7z|aac|arc|arj|asf|asx|avi|bin|csv|doc|exe|flv|gif|gz|gzip|hqx|jar|jpe?g|js|mp(2|3|4|e?g)|mov(ie)?|msi|msp|pdf|phps|png|ppt|qtm?|ra(m|r)?|sea|sit|tar|tgz|torrent|txt|wav|wma|wmv|wpd||xls|xml|z|zip',

@robocoder
Copy link
Contributor

Note: this is configurable via addDownloadExtensions() or setDownloadExtensions().

  • Consider adding 'bz2|tbz2' to the mix;
  • Re-visit the algorithm to make sure it's only matching on the filename and not URL parameters.

@robocoder
Copy link
Contributor

Update QUnit while you're at it.

http://dev.jquery.com/browser/trunk/qunit

@robocoder
Copy link
Contributor

In [1488], refs #995 - update Qunit

@robocoder
Copy link
Contributor

In [1508], fixes #995 - add bz2 (and tbz2) to list of recognized download extensions;
fix regression in [1488], where qunit no longer defines url() helper function;
fix bug in getLinkType() where it could match an extension in url params (false positive);
fixes #1007 - workaround Opera 9.22 parse bug, replacing // with new RegExp() syntax

@robocoder
Copy link
Contributor

In [1555], refs #995 - also handle .bz and .tbz (e.g., still used by freebsd ports)

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Development

No branches or pull requests

2 participants