New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geo location should detect country, region and city from IPv6 addresses #3581
Comments
Attachment: Patch for Piwik's bundled MaxMind PHP GeoIP libs |
The PECL GeoIP doesn't support IPv6 yet. However, a patch is available here: https://bugs.php.net/bug.php?id=59124 I've attached a patch to make piwik's MaxMind PHP lib play nice with the other patch. |
Attachment: GeoIP changes for IPv6 |
Here's a somewhat complete changeset that would be required for IPv6 Support. I have tested it on Fedora 18: Apache 2.4 with PHP 5.4.9, latest mod_geoip2 master branch from https://github.com/maxmind/geoip-api-mod_geoip2 (should work on 1.2.7 though) and patched PECL GeoIP with Patch from https://bugs.php.net/bug.php?id=59124 Haven't tested on non patched/stable environment yet as I didn't have the time to set up a clean VM for that yet. So I'd appreciate any testing :) |
@heffer Thanks for the patch. It does look interesting and we would like to consider committing the patch. Can you please add some tests? For example maybe you could update this test: ManyVisitorsOneWebsiteTest.php See test instructions: https://github.com/piwik/piwik/blob/master/tests/README.txt with tests we can safely consider the code and check it's working! |
I will look into writing the tests during the Christmas break because I'm pretty busy right now. If you need it before then we'd need to find someone else to do it. |
We don't need it quickly (it is a bonus for us that you worked on it), after Christmas will be perfect, thanks so much! |
@heffer any update on Geoip with ipv6 support? thanks for your time! |
bump! hello everybody... is there a patch for ipv6 adresses? many thanks! |
I stopped working on this after noticing that the tests were somewhat broken. I can't remember what the exact issue was, it's been some months. However, currently I can't find the time to work on this right now. |
thanks for the answer. Actually I opened another ticked because i noticed that there are two free databases http://dev.maxmind.com/geoip/legacy/geolite/ it is not possible to simply merge the two databases? (noob question probably) |
Could you maybe update the patch against the current release? Was it already considered by the devs maybe? Anything wrong with it? |
The patch looks fine! I'd like to commit it to Piwik. If you can make a pull request (after testing that it works), we will do our best to merge quickly! cheers |
see also #4487: New feature: Make geoip backend work with geoip2 |
see also: #5348 GeoIP Server (Apache module) compatibility with IP V6 |
There seems to be an aggravation, noticed in Piwik v2.8.1: Pls look at #4391 too. |
@mygithuber thanks for the report! Can you please create a new issue with your report? it will help schedule work on the fix faster. thanks! for more info on how we manage backlog http://developer.piwik.org/guides/core-team-workflow#how-we-organise-issues |
Check out the Pull request being discussed: IPv6 support #6574 |
you will be helped by service Geolocation IpV4, IpV6, domains name |
The text was updated successfully, but these errors were encountered: