New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate UserSettings plugin -> use DeviceDetection instead! #3962
Comments
A bug was reported here: http://forum.piwik.org/read.php?2,105199,page=1#msg-105459
|
The root cause of this bug is the VARCHAR(10) config_* fields and the reporter's MySQL-Server running in "strict mode". Since the config_os_version string "Server 2003" is 11 chars in length, MySQL in standard config would just cut the string to "Server 200"; MySQL running in strict mode throws an error and stops script execution. I reported the issue back to Clearcode and Pjotr is working on a fix; Which could just be raise the width of the config_* fields. |
small note: As soon as that plugin is finished, we should also move the translations to the core file (to be consitent with all other plugins included in core) |
The bug fields config_os_version and config_device_type are not large enough was fixed in #4203 |
Unit tests for the UserAgentEnhanced were added in: #115 |
Changing scope to: Move DevicesDetection out of beta and enabled by default. |
Increasing priority as more people report issues in UserAgentParser. We need to clarify our vision to the community. Btw random idea; Maybe it would be a good idea to make UserAgentParserEnhanced a separate open source project, hosted in the piwik family at github? For this ticket though, the concept is to reomve completely UserAgentParser from codebase and remove completely the previous User Settings reports. This will be awesome and has been long overdue :) If anyone wants to own this ticket, please go ahead, this would make a great different to cleaning up the last "pending migration" to our superb new & organised Piwik platform. |
I'm currently writing a plugin, but when I'm done I could have a look at that task. Moving the Useragentparser to a seperate repo sounds good. Would you create a repository and give me access. So we can move the required files there. Btw. We need to merge my pull request regarding the devicedetection first! Do you have some time to have a look at it? |
Great to hear you'd be interested to work on this! :) it will be such a good feeling to deprecate the old UserSettings code and keep things tidy. I'll update the ticket description later with some clarifications in the spec. Re: repo we will directly compete with other libs such as https://github.com/tobie/ua-parser or many others... |
See #4965: Use new device-detector library in Piwik to detect browsers, systems, |
The universal Device Detector library is now available as Free software and hosted on github here: https://github.com/piwik/device-detector We will now work on closing this ticket and finishing the loop nicely! |
see #5329 Enable DevicesDetection plugin by default |
We migrated to Device detector V2 in this pull request: #305 (comment) Nice progress :) |
@mattab Besides fixing the update script, is there anything still open to solve this issue? |
Hi @sgiehl, Regarding this issue, I think it is mostly done!
Regarding next step: we can leave the
(Kinda related to #6782) |
I have thought about moving the images to DevicesDetection plugin. The reason why I haven't done it yet is that I wasn't sure if it might break any older reports containing those as external images or something like that. Do you think it should be save moving them? Moving those stuff to own/other plugins sounds good. So creating new tickets should be fine. |
+1 for moving images to proper plugin. Ideally all clients will use our |
Maybe could be worth mentioning in Developer changelog as "information" |
All reports and API methods are moved now. Last remaining part is the page template showing the reports |
Nice work @sgiehl - it would be nice to get it done in 2.11.0 and this would successfully conclude this project! :) |
Hm. I'm not sure where to move the template displaying the various reports. |
Not sure how this should be solved but it seems good use case for the platform, to let plugins enrich existing reports with their data. ideally we would provide a nice API for plugins to compose report pages.
Thoughts? |
I'm not sure how to solve that best. Maybe we should reorganize the technical reports. We currently have:
I don't think that this splitting makes much sense. Maybe something like that would fit more:
I would maybe remove the Configurations completely or make it available as widget only. Not sure if that report is useful at all. |
maybe we could also move "Resolution" into "Devices" ?
we need to find shorter name so it fits in the sub-menu... do you maybe have an idea?
it's a useful report, some users have mentioned using it before (in the forums and in the tracker). Although maybe we could move this feature into a plugin that would be on the Marketplace rather than in core?
👍 |
Hi @sgiehl the UserSettings plugin looks now quite "deprecated" and almost empty. maybe we close this issue and create smaller follow up issue? |
Yes. Let's create follow ups. |
In Piwik 1.12 we added the DevicesDetection plugin to provide advanced user detection of mobile devices, tvs, consoles, brands, models, Operating systems versions, etc. The code is still beta and we know covers only 50-80% of all devices.
Now that this plugin works well, we note redundancy between DevicesDetection algorithm and UserSettings.
eg the Following reports are processed and displayed in both plugins:
Tasks
Here is how to solve the redundancy and make code unified.
general
API:
Core:
Tests & Backward compatibility
Tracker:
At the end of this ticket we will see:
See also: Help improve DevicesDetection plugin: see matomo-org/device-detector#4215
The text was updated successfully, but these errors were encountered: