Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Segment Editor to the Iframed embed dashboard #4502

Closed
mattab opened this issue Jan 12, 2014 · 9 comments
Closed

Add Segment Editor to the Iframed embed dashboard #4502

mattab opened this issue Jan 12, 2014 · 9 comments
Assignees
@mattab
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone
2.1

Comments

@mattab
Copy link
Member

mattab commented Jan 12, 2014

Currently the Custom Segments editor is not displayed on the embed dashboard iframe, eg:

http://demo.piwik.org/index.php?module=Widgetize&action=iframe&moduleToWidgetize=Dashboard&actionToWidgetize=index&idSite=7&period=week&date=yesterday

  • We could add the Custom Segments editor in this view (by default)

Also a related UX improvement:

  • The Widgets & Dashboard box, should be white and look like the calendar (Morpheus theme). Currently it looks grey (Zeitgeist theme)

Keywords: academy
@mattab
Copy link
Member Author

mattab commented Jan 12, 2014

Attachment:
embed dashboard 2.0.3.png

@mattab
Copy link
Member Author

mattab commented Jan 16, 2014

  • Add UI test for this dashboard

@mattab
Copy link
Member Author

mattab commented Jan 16, 2014

In e30df99: Remove top_controls_inner div + other fixes, preparing for this ticket refs #4502

@mattab
Copy link
Member Author

mattab commented Jan 16, 2014

In dda83f4: Refs #4502 Styling embed dashboard menu

@mattab
Copy link
Member Author

mattab commented Jan 16, 2014

In a0049d6: Refs #4502 Adding class for standalone widgets

@mattab
Copy link
Member Author

mattab commented Jan 16, 2014

In e46bc6b: Refs #4502 Fix segment editor so it works when used without the #hashTag and load from URL GET param

@mattab
Copy link
Member Author

mattab commented Jan 16, 2014

In a6a7288: Refs #4502 Make menu look and feel consistent

@mattab
Copy link
Member Author

mattab commented Jan 20, 2014

Fixed in commit where I added the screenshot test for the Embed dashboard: https://github.com/piwik/piwik-ui-tests/blob/8fa347b23801387ff5d31e4c252f7418cdb3e197/expected-ui-screenshots/UIIntegrationTest_widgetize_dashboard.png

@mattab
Copy link
Member Author

mattab commented Jan 22, 2014

In c4708dc: Refs #4502 Fix bug in segment editor when editing as a view/admin user.

@mattab mattab added this to the 2.1 - Piwik 2.1 milestone Jul 8, 2014
@mattab mattab self-assigned this Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Remove top_controls_inner div + other fixes, preparing for this ticke…
e30df99 
…t refs matomo-org#4502
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#4502 Styling embed dashboard menu
dda83f4
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#4502 Adding class for standalone widgets
a0049d6
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#4502 Fix segment editor so it works when used without…
e46bc6b 
… the #hashTag and load from URL GET param
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#4502 Make menu look and feel consistent
a6a7288
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#4502 Fix bug in segment editor when editing as a view…
c4708dc 
…/admin user.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattab mattab

Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
1 participant
@mattab