Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically activate/deactivate the 'Login' plugin when activating another Login plugin (eg. LdapLogin) #4529

Closed
mattab opened this issue Jan 15, 2014 · 2 comments
Closed

Automatically activate/deactivate the 'Login' plugin when activating another Login plugin (eg. LdapLogin) #4529

mattab opened this issue Jan 15, 2014 · 2 comments
Assignees
@mattab
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone
2.1

Comments

@mattab
Copy link
Member

mattab commented Jan 15, 2014

LdapLogin developer has found a bug: disabling the Login plugin within the LdapLogin activate() method, will not disable the Login plugin.

Let's fix it since it will solve the nice use case: when LdapLogin is enabled, the default Login plugin is disabled. When it Ldap is disabled, back to using default Login plugin... nice!
@mattab
Copy link
Member Author

mattab commented Jan 15, 2014

In 4f9faf4: Refactor Manager around enable/disable of plugins: Fixes #4529 Login plugin can be enabled/disabled ie. when disabling/enabling LoginLdap
was reported in http://forum.piwik.org/read.php?9,109016

@anonymous-matomo-user
Copy link

Thank you! Tested and confirmed as fixed.

@mattab mattab added this to the 2.1 - Piwik 2.1 milestone Jul 8, 2014
@mattab mattab self-assigned this Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refactor Manager around enable/disable of plugins: Fixes matomo-org#4529
4f9faf4 
 Login plugin can be enabled/disabled ie. when disabling/enabling LoginLdap

was reported in http://forum.piwik.org/read.php?9,109016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattab mattab

Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
2 participants
@mattab @anonymous-matomo-user