Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linking to #hash tag does not work after merging AngularJS #4795

Closed
mattab opened this issue Mar 4, 2014 · 2 comments
Closed

linking to #hash tag does not work after merging AngularJS #4795

mattab opened this issue Mar 4, 2014 · 2 comments
Assignees
@tsteur
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
2.2.1

Comments

@mattab
Copy link
Member

mattab commented Mar 4, 2014

Hash tag links are rewritten with a leading slash.

For example linking to

index.php?module=UsersManager&action=index&idSite=1&period=year&date=today#super_user_access

redirects to:

index.php?module=UsersManager&action=index&idSite=1&period=year&date=today#/super_user_access

And user is not redirect to the right spot on the page.

Expected:

  • that there is a way for us to link to particular DIVs on the page. WHat is the proper way to do this with AngularJS?
  • if the way to link to hash tags has to change, then let's rewrite existing links to hash tags (there are only a few in the UI) to follow the new system
@tsteur
Copy link
Member

tsteur commented Mar 12, 2014

After trying to solve this issue for a while I found the related ticket on AngularJS side: angular/angular.js#4608

A fix seems to be pretty complicated, requires a larger rewrite in Angular and will be maybe fixed in Angular 1.3

I might have at least a partial solution, will have a look again tomorrow.

@tsteur
Copy link
Member

tsteur commented Mar 12, 2014

Done. See 37de7c8

@mattab mattab added this to the 2.2.1 - Piwik 2.2.1 milestone Jul 8, 2014
@tsteur tsteur mentioned this issue Mar 12, 2014
Closed
@tsteur tsteur modified the milestones: 2.4.0 - Piwik 2.4.0, 2.2.1 - Piwik 2.2.1 Jul 11, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
2.2.1
Development

No branches or pull requests
2 participants
@tsteur @mattab