New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VisitFrequency API: read pre 2.0 data #4878
Comments
Attachment: I think incorrect fix :( |
The complicated thing is to deal with cases where the data spans across multiple days or weeks or months. In this case the API must both select the old data and the new one and then merge these two datasets into the returning datatable. |
build is failing, reopening |
I have tested as follows:
What I see:
See attached screenshot. can you reproduce? |
Attachment: |
In 99319ec: Refs #4878 typos @diosmosis please add integration test triggering this code path |
Call to undefined method Piwik\Plugins\VisitFrequency\API::addPrePiwik2DataIfMissing() |
Tested w/ updated piwik 1.12 install, works. Closing. |
…post-piwik 2 data cannot be found. Commit includes commented out tests for changes.
…ggering this code path
…DataAbsent and add test for multiple periods w/ pre Piwik 2 VisitFrequency data.
…to successfully combine pre-2.0 VisitFrequency data with new data.
…ency archiving and fix errors in build.
…isitors for visit frequency api that caused fixture to fail when running UI tests.
in VisitFrequency API in 2.0 we started processing data for a segment:
In pre 2.0 it used to be recorded as metrics in the VisitFrequency plugin archives.
Let's add a few lines of code to read the data from pre-2.0 format, when the $date is earlier than Dec 17th (date of 2.0 release)
This is a follow up of the change in a701d4a
The text was updated successfully, but these errors were encountered: