Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Custom segment" instead of real name #5053

Closed
gaumondp opened this issue Apr 28, 2014 · 3 comments
Closed

"Custom segment" instead of real name #5053

gaumondp opened this issue Apr 28, 2014 · 3 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@gaumondp
Copy link

Maybe it's on purpose but selecting a Segment with the Segment editor doesn't use the name we gave to the Segment itself but "reverts" to a generic "CUSTOM SEGMENT" in the dropdown Segment selector.

I like the fact that it turns red to show it isn't the default but the real name (in red) of the segment should be there instead of the generic one.

@mattab
Copy link
Member

mattab commented Apr 30, 2014

It sounds like a bug so we'd like to investigate and fix it.

Can you please explain

  • what segment you defined
  • what browser you use
  • How to reproduce this issue (step by step)

@gaumondp
Copy link
Author

Using Piwik 2.2 (April 17)
Manual upgrade/installation
Browser Chrome 34 (or IE8) under Windows XP, using Piwik in English
All segments created as the Piwik SuperAdmin

Segment names that get rewritten to "Custom Segment" (name and segment type) :
"Externe Seul" / visitIP<
"Interne seul" / visitIP>=
"Plus 500 actions" actions > 499
"Tests" / visitIP<

Those are showing their name:
"Publications" / pageURL
"Un IP" / visitIP ==
"Vidos" / pageURL

Looking at the kind of segment condition it looks like the bug is comming from there...

A brand new "Post22" with pageURL as segement type is showing ok. If I recycle the same segment and change its condition to "visitIP" and a "at least" it then revert to "Custom segment" instead of "Post22".

Dali

@tsteur
Copy link
Member

tsteur commented May 7, 2014

In 3abffcf: fixes #5053 this should fix the segment title defaults to "custom segment" in case a comparison like >= or <= is used. Thx for the good step by step instructions

@gaumondp gaumondp added this to the 2.3.0 - Piwik 2.3.0 milestone Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
…custom segment" in case a comparison like >= or <= is used. Thx for the good step by step instructions
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

3 participants